Page MenuHomePhabricator

[lib] Introduce combined padding interface
ClosedPublic

Authored by bartek on Mar 13 2023, 7:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 20, 3:03 AM
Unknown Object (File)
Sun, Feb 18, 11:38 PM
Unknown Object (File)
Sun, Feb 18, 7:18 PM
Unknown Object (File)
Sun, Feb 18, 6:11 PM
Unknown Object (File)
Sun, Feb 18, 4:43 PM
Unknown Object (File)
Sun, Feb 18, 1:41 PM
Unknown Object (File)
Feb 1 2024, 3:38 AM
Unknown Object (File)
Dec 17 2023, 3:14 AM

Details

Summary

Part of ENG-3099

This diff is combining two previous diffs and finally allows to pad the data to multiples of 10KB (forty 250-byte blocks)

The whole idea is described in this Notion doc.

Depends on D7060

Test Plan

Added unit tests. Also tested using my CLI tool and hex editor / viewer (e.g. xxd tool). The CLI tool is also available in the Notion doc above

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
lib/utils/pkcs7-padding.js
172–178 ↗(On Diff #23693)

This might be considered as an anti-pattern but I have no better idea (besides simply exporting them all)

bartek published this revision for review.Mar 13 2023, 8:11 AM
bartek removed a reviewer: anunay.
bartek added a subscriber: anunay.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

This revision is now accepted and ready to land.Mar 20 2023, 7:07 AM