Paths

Table of Contentst

[lib] Introduce superblock padding
ClosedPublic
Actions

Authored by bartek on Mar 13 2023, 2:44 PM.

Details

Reviewers

atul
marcin
tomek

Commits

rCOMMe44805bae320: [lib] Introduce superblock padding

Summary

Part of ENG-3099

This diff implements modified PKCS#7 padding, which operates on block basis, instead of byte basis.
It is described in this Notion doc.

Depends on D7059

Test Plan

Added unit tests. Also tested using my CLI tool and hex editor / viewer (e.g. xxd tool). The CLI tool is also available in the Notion doc above

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 13 2023, 2:44 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 13 2023, 2:44 PM

bartek added a child revision: D7061: [lib] Introduce combined padding interface.Mar 13 2023, 2:46 PM

bartek edited the summary of this revision. (Show Details)Mar 13 2023, 2:47 PM

bartek edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B17293: Diff 23692.Mar 13 2023, 2:59 PM

bartek published this revision for review.Mar 13 2023, 3:10 PM

bartek removed a reviewer: anunay.

bartek added a subscriber: anunay.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

This revision is now accepted and ready to land.Mar 17 2023, 9:11 PM

Putting it in scripts/ sounds like a good idea to me!

In D7060#210983, @ashoat wrote:

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Unable to see F436096?

Fixed

Rebase, fix exports

Harbormaster completed remote builds in B17482: Diff 23947.Mar 21 2023, 4:43 PM

Closed by commit rCOMMe44805bae320: [lib] Introduce superblock padding. · Explain WhyMar 21 2023, 5:21 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe44805bae320: [lib] Introduce superblock padding.

Revision Contents
Changeset List

Path

Size

lib/

utils/

pkcs7-padding.js

82 lines

pkcs7-padding.test.js

81 lines

Diff 23950

View Options

lib/utils/pkcs7-padding.js