Page MenuHomePhabricator

[lib] Introduce superblock padding
ClosedPublic

Authored by bartek on Mar 13 2023, 7:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 18, 11:01 PM
Unknown Object (File)
Sun, Feb 18, 6:40 PM
Unknown Object (File)
Sun, Feb 18, 5:40 PM
Unknown Object (File)
Sun, Feb 18, 3:46 PM
Unknown Object (File)
Sun, Feb 18, 1:09 PM
Unknown Object (File)
Sun, Feb 11, 3:45 PM
Unknown Object (File)
Dec 16 2023, 8:38 PM
Unknown Object (File)
Oct 28 2023, 3:41 AM

Details

Summary

Part of ENG-3099

This diff implements modified PKCS#7 padding, which operates on block basis, instead of byte basis.
It is described in this Notion doc.

Depends on D7059

Test Plan

Added unit tests. Also tested using my CLI tool and hex editor / viewer (e.g. xxd tool). The CLI tool is also available in the Notion doc above

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek edited the test plan for this revision. (Show Details)
bartek published this revision for review.Mar 13 2023, 8:10 AM
bartek removed a reviewer: anunay.
bartek added a subscriber: anunay.

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

This revision is now accepted and ready to land.Mar 17 2023, 2:11 PM

Screenshot 2023-03-20 at 3.04.20 PM.png (674×1 px, 191 KB)

Putting it in scripts/ sounds like a good idea to me!

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Unable to see F436096?

This revision was automatically updated to reflect the committed changes.