Page MenuHomePhabricator
Differential D7060

[lib] Introduce superblock padding
ClosedPublic
Actions

Authored by bartek on Mar 13 2023, 7:44 AM.
Tags
None
Referenced Files
F3394218: D7060.diff
Sat, Nov 30, 6:20 PM
Unknown Object (File)
Sun, Nov 10, 7:02 PM
Unknown Object (File)
Sun, Nov 10, 11:17 AM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Fri, Nov 8, 9:23 PM
Unknown Object (File)
Tue, Nov 5, 2:10 AM
Unknown Object (File)
Oct 24 2024, 2:38 AM
View All 85 Files
Subscribers
anunay
ashoat
tomek

Details

Reviewers
atul
marcin
tomek
Commits
rCOMMe44805bae320: [lib] Introduce superblock padding
Summary

Part of ENG-3099

This diff implements modified PKCS#7 padding, which operates on block basis, instead of byte basis.
It is described in this Notion doc.

Depends on D7059

Test Plan

Added unit tests. Also tested using my CLI tool and hex editor / viewer (e.g. xxd tool). The CLI tool is also available in the Notion doc above

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Mar 13 2023, 7:44 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 13 2023, 7:44 AM
bartek added a child revision: D7061: [lib] Introduce combined padding interface.Mar 13 2023, 7:46 AM
bartek edited the summary of this revision. (Show Details)Mar 13 2023, 7:47 AM
bartek edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B17293: Diff 23692.Mar 13 2023, 7:59 AM
bartek published this revision for review.Mar 13 2023, 8:10 AM
bartek removed a reviewer: anunay.
bartek added a subscriber: anunay.
atul added a reviewer: tomek.Mar 16 2023, 1:37 PM

Specifically adding @tomek as reviewer since he seemed to have some thoughts during the Encryption Sync (that might've been discussed offline?)

atul accepted this revision.Mar 17 2023, 2:11 PM

The Notion doc was super helpful for understanding what's going on. Thanks for taking the time to write that all out.

This revision is now accepted and ready to land.Mar 17 2023, 2:11 PM
ashoat added a comment.EditedMar 20 2023, 2:04 PM

Screenshot 2023-03-20 at 3.04.20 PM.png (674×1 px, 191 KB)

Putting it in scripts/ sounds like a good idea to me!

atul added a comment.Mar 20 2023, 2:48 PM
In D7060#210983, @ashoat wrote:

{F436096}

Putting it in scripts/ sounds like a good idea to me!

Unable to see F436096?

ashoat added a comment.EditedMar 20 2023, 3:10 PM

Fixed

bartek updated this revision to Diff 23947.Mar 21 2023, 9:27 AM

Rebase, fix exports

Harbormaster completed remote builds in B17482: Diff 23947.Mar 21 2023, 9:43 AM
Closed by commit rCOMMe44805bae320: [lib] Introduce superblock padding (authored by bartek). · Explain WhyMar 21 2023, 10:21 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMe44805bae320: [lib] Introduce superblock padding.

Revision Contents
Changeset List

PathSize
lib/
utils/
83 lines
81 lines

Diff 23692

View Options

lib/utils/pkcs7-padding.js

Loading...
View Options

lib/utils/pkcs7-padding.test.js

Loading...