Page MenuHomePhabricator
Differential D7070

[web] Add `CryptoStore` to `persistConfig.whitelist`
ClosedPublic
Actions

Authored by atul on Mar 14 2023, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 8:19 PM
Unknown Object (File)
Sun, Nov 24, 7:02 PM
Unknown Object (File)
Tue, Nov 19, 10:00 AM
Unknown Object (File)
Tue, Nov 19, 10:00 AM
Unknown Object (File)
Tue, Nov 19, 10:00 AM
Unknown Object (File)
Tue, Nov 19, 10:00 AM
Unknown Object (File)
Tue, Nov 19, 9:59 AM
Unknown Object (File)
Tue, Nov 19, 9:36 AM
View All Files
Subscribers
kamil
tomek

Details

Reviewers
ashoat
marcin
kamil
Commits
rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist`
Summary

We were previously excluding CryptoStore from redux-persist as we were working to avoid having to create a ton of migrations.

But now that we have primaryAccount/notificationAccount and primaryIdentityKeys/notificationIdentityKeys I think things are stable in the short term and we can start persisting.

Depends on D7081

Test Plan

Reload page and see that cryptoStore is included in REHYDRATE action:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Mar 14 2023, 2:28 PM
Herald added a subscriber: tomek. · View Herald TranscriptMar 14 2023, 2:28 PM
Harbormaster completed remote builds in B17333: Diff 23740.Mar 14 2023, 2:43 PM
atul requested review of this revision.Mar 14 2023, 2:43 PM
ashoat accepted this revision.Mar 14 2023, 6:36 PM
This revision is now accepted and ready to land.Mar 14 2023, 6:36 PM
ashoat added a reviewer: kamil.Mar 14 2023, 6:36 PM
ashoat added a subscriber: kamil.

FYI @kamil, another thing we'll need to move to SQLite

atul edited the summary of this revision. (Show Details)Mar 15 2023, 1:12 PM
atul added a parent revision: D7081: [web] Update `getSignedIdentityKeysBlobSelector` to `await initOlm();`.
atul updated this revision to Diff 23770.Mar 15 2023, 1:16 PM

rebase

Harbormaster completed remote builds in B17353: Diff 23770.Mar 15 2023, 1:31 PM
atul added a child revision: D7082: [keyserver] Handle `SIGNED_IDENTITY_KEYS_BLOB` response.Mar 15 2023, 1:42 PM
atul updated this revision to Diff 23775.Mar 15 2023, 4:12 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 15 2023, 4:20 PM
Closed by commit rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6bfaf0746b8f: [web] Add `CryptoStore` to `persistConfig.whitelist`.
Harbormaster completed remote builds in B17357: Diff 23775.Mar 15 2023, 4:27 PM

Revision Contents
Changeset List

PathSize
web/
2 lines

Diff 23776

View Options

web/root.js

Loading...