Paths

Table of Contentst

[lib] Shim encrypted multimedia
ClosedPublic
Actions

Authored by bartek on Mar 24 2023, 4:44 AM.

Details

Reviewers

atul
marcin
ashoat
rohan

Commits

rCOMM3221e11cbbc6: [lib] Shim encrypted multimedia

Summary

Linear task: ENG-1335

Added a condition to shim messages with types encrypted_{photo,video} as UNSUPPORTED. Added a note how to unshim them when supported.

Modified robotext to display new media types correctly.

Depends on D7168

Test Plan

Modified keyserver's upload-fetchers.js to send media messages with type encrypted_photo. On native wiped state and ensured that robotext is displayed.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 24 2023, 4:44 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptMar 24 2023, 4:44 AM

Harbormaster completed remote builds in B17580: Diff 24068.Mar 24 2023, 4:59 AM

bartek added a child revision: D7170: [lib] Store encrypted messages in Client DB.Mar 24 2023, 5:29 AM

bartek published this revision for review.Mar 24 2023, 5:32 AM

ashoat accepted this revision.Mar 24 2023, 11:53 AM

This revision is now accepted and ready to land.Mar 24 2023, 11:53 AM

rohan accepted this revision.Mar 27 2023, 3:24 PM

Closed by commit rCOMM3221e11cbbc6: [lib] Shim encrypted multimedia (authored by bartek). · Explain WhyMar 30 2023, 11:45 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3221e11cbbc6: [lib] Shim encrypted multimedia.

Revision Contents
Changeset List

Path

Size

lib/

media/

media-utils.js

4 lines

shared/

messages/

multimedia-message-spec.js

13 lines

Diff 24459

View Options

lib/media/media-utils.js