Page MenuHomePhabricator
Differential D7197

[Web] Package opaque-ke-wasm files
ClosedPublic
Actions

Authored by • jon on Mar 27 2023, 7:34 AM.
Tags
None
Referenced Files
F3529467: D7197.diff
Tue, Dec 24, 6:59 PM
Unknown Object (File)
Sun, Dec 22, 7:12 PM
Unknown Object (File)
Sat, Dec 7, 8:17 PM
Unknown Object (File)
Sat, Dec 7, 7:20 AM
Unknown Object (File)
Sat, Dec 7, 7:19 AM
Unknown Object (File)
Thu, Dec 5, 8:32 PM
Unknown Object (File)
Thu, Dec 5, 8:32 PM
Unknown Object (File)
Thu, Dec 5, 8:32 PM
View All Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMMac918b353479: [Web] Package opaque-ke-wasm files
Summary

Include generated wasm files, and add script to create them.

https://linear.app/comm/issue/ENG-3387

Test Plan

Not sure about packaging this with npm, but the script can be tested:

cd web/opaque-ke-wasm/
yarn build
ls pkg/

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Mar 27 2023, 7:34 AM
Herald added subscribers: atul, tomek. · View Herald TranscriptMar 27 2023, 7:34 AM
Harbormaster completed remote builds in B17683: Diff 24206.Mar 27 2023, 7:49 AM
• jon requested review of this revision.Mar 27 2023, 7:49 AM
• jon added inline comments.Mar 27 2023, 7:49 AM
web/opaque-ke-wasm/package.json
8–10 ↗(On Diff #24206)

not sure if this is supposed to be a flat list, or reflect the structure when publishing.

• jon added a parent revision: D7155: [Native] Migrate native_rust_library to use identity client stubs.Mar 27 2023, 9:14 AM
• jon retitled this revision from [Web] Package wasm files to [Web] Package opaque-ke-wasm files.
ashoat added a comment.Mar 27 2023, 9:45 AM

After running yarn arcpatch D7197, I noticed that the commit before this one is D7155. Does this work depend on D7155? If so, can you specify the stack on Phabricator?

ashoat added a child revision: D7201: [web][keyserver] Webpack config and client logic to access opaque-ke2 WASM bindings.Mar 27 2023, 11:09 AM
ashoat updated this revision to Diff 24232.Mar 27 2023, 1:10 PM

Fixes after in work in the subsequent diff

ashoat accepted this revision.Mar 27 2023, 1:18 PM
This revision is now accepted and ready to land.Mar 27 2023, 1:18 PM
Harbormaster completed remote builds in B17704: Diff 24232.Mar 27 2023, 1:25 PM
• jon added a comment.Mar 27 2023, 2:15 PM

After running yarn arcpatch D7197, I noticed that the commit before this one is D7155. Does this work depend on D7155? If so, can you specify the stack on Phabricator?

I eventually did this, but thanks for the reminder.

• jon added inline comments.Mar 27 2023, 2:19 PM
web/opaque-ke-wasm/package.json
7 ↗(On Diff #24232)

should this be removed? we switched main to something else.

ashoat added inline comments.Mar 27 2023, 3:21 PM
web/opaque-ke-wasm/package.json
7 ↗(On Diff #24232)

Good call!! It should be removed from both this list and from Git entirely

• jon updated this revision to Diff 24286.Mar 28 2023, 8:41 AM
• jon marked an inline comment as done.

Remove index.js stub

• jon added a comment.Mar 28 2023, 8:42 AM

address feedback

Harbormaster completed remote builds in B17746: Diff 24286.Mar 28 2023, 8:57 AM
Closed by commit rCOMMac918b353479: [Web] Package opaque-ke-wasm files (authored by • jon). · Explain WhyMar 28 2023, 10:45 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMac918b353479: [Web] Package opaque-ke-wasm files.

Revision Contents
Changeset List

PathSize
web/
opaque-ke-wasm/
12 lines

Diff 24296

View Options

web/opaque-ke-wasm/index.js

Loading...
View Options

web/opaque-ke-wasm/package.json

Loading...