Paths

Table of Contentst

-
native/native_rust_library/src/
-
native_rust_library/
-
src/
-
identity_client.rs
1/2
lib.rs

[Native] Update native_rust_library ffi to reflect client gRPC
ClosedPublic
Actions

Authored by • jon on Mar 27 2023, 8:57 AM.

Details

Reviewers

ashoat
varun
bartek

Commits

rCOMMd0fc17f6bff6: [Native] Update native_rust_library ffi to reflect client gRPC

Summary

Update ffi to avoid merge conflicts between varun and I.

https://linear.app/comm/issue/ENG-3385

Test Plan

cd native/native_rust_library
cargo build

Android build gate

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Mar 27 2023, 8:57 AM

Herald added subscribers: atul, tomek. · View Herald TranscriptMar 27 2023, 8:57 AM

• jon added a parent revision: D7155: [Native] Migrate native_rust_library to use identity client stubs.Mar 27 2023, 8:57 AM

Harbormaster completed remote builds in B17696: Diff 24221.Mar 27 2023, 9:12 AM

• jon requested review of this revision.Mar 27 2023, 9:12 AM

• jon added a child revision: D7200: [Comm-opaque2] Add grpc helper for wrapped protocol error.Mar 27 2023, 10:42 AM

varun accepted this revision.Mar 27 2023, 1:48 PM

This revision is now accepted and ready to land.Mar 27 2023, 1:48 PM

Closed by commit rCOMMd0fc17f6bff6: [Native] Update native_rust_library ffi to reflect client gRPC (authored by • jon). · Explain WhyMar 27 2023, 2:19 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMd0fc17f6bff6: [Native] Update native_rust_library ffi to reflect client gRPC.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

identity_client.rs

32 lines

lib.rs

93 lines

Diff 24238

View Options

native/native_rust_library/src/identity_client.rs

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines