Page MenuHomePhabricator

[lib][web][native] Introduce commServicesAccessToken to Redux state
ClosedPublic

Authored by ashoat on Mar 27 2023, 8:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 8:50 PM
Unknown Object (File)
Tue, Mar 5, 8:49 PM
Unknown Object (File)
Tue, Mar 5, 8:49 PM
Unknown Object (File)
Tue, Feb 27, 10:15 AM
Unknown Object (File)
Tue, Feb 27, 10:15 AM
Unknown Object (File)
Tue, Feb 27, 10:15 AM
Unknown Object (File)
Tue, Feb 27, 10:15 AM
Unknown Object (File)
Tue, Feb 27, 10:13 AM
Subscribers

Details

Summary

We'll use this to track the access token used to authenticate the client to Comm services.

Test Plan

I just tested this with Flow for now, but I'll test it more thoroughly in combination with the following diffs, and will wait to land it until then

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Add to redux-persist allowlist on native

LGTM, ill defer to react/redux people for correctness

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

This revision is now accepted and ready to land.Mar 28 2023, 1:27 PM
In D7212#214878, @atul wrote:

Might be missing something, but should we add a migration to native that adds commServicesAccessToken field to Redux if it doesn't already exist?

No reason to do that, I think... it would just set commServicesAccessToken to null, but state.commServicesAccessToken already returns undefined...

There will be follow-up diffs here for the reducer etc., though