Page MenuHomePhabricator
Differential D7256

[identity] bump aws-config and aws-sdk-dynamodb crate versions
ClosedPublic
Actions

Authored by varun on Mar 30 2023, 12:27 PM.
Tags
None
Referenced Files
F2154707: D7256.id.diff
Sun, Jun 30, 7:51 PM
Unknown Object (File)
Wed, Jun 26, 7:03 PM
Unknown Object (File)
Wed, Jun 26, 3:46 PM
Unknown Object (File)
Mon, Jun 24, 1:26 PM
Unknown Object (File)
Sat, Jun 22, 4:44 PM
Unknown Object (File)
May 30 2024, 11:50 AM
Unknown Object (File)
May 28 2024, 10:13 AM
Unknown Object (File)
May 28 2024, 10:13 AM
View All 66 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• jon
bartek
Commits
rCOMMf30a02df6cdd: [identity] bump aws-config and aws-sdk-dynamodb crate versions
Summary

these were pretty outdated. tested a couple client calls to DDB to make sure nothing broke

Test Plan

called the generate nonce and get user ID RPCs and the DDB client was able to read from/write to test tables

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mar 30 2023, 12:27 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 30 2023, 12:27 PM
varun added a child revision: D7258: [identity] config for LocalStack.Mar 30 2023, 12:33 PM
Harbormaster completed remote builds in B17841: Diff 24437.Mar 30 2023, 12:48 PM
varun requested review of this revision.Mar 30 2023, 12:48 PM
ashoat added inline comments.Mar 30 2023, 1:50 PM
services/identity/Cargo.toml
17 ↗(On Diff #24437)

Other services use 0.51.0... wondering if we care to keep them synced?

varun added inline comments.Mar 30 2023, 1:56 PM
services/identity/Cargo.toml
17 ↗(On Diff #24437)

i'd like to use the latest here, and i don't really want to upgrade the other services...

it would be great to keep them in sync, though. I'll link this issue in ENG-2311

varun added inline comments.Mar 30 2023, 2:00 PM
services/identity/Cargo.toml
17 ↗(On Diff #24437)

linked on 3102 instead

varun added a reviewer: bartek.Mar 30 2023, 3:23 PM
bartek accepted this revision.Mar 31 2023, 4:14 AM
bartek added inline comments.
services/identity/Cargo.toml
17 ↗(On Diff #24437)

Agree, let's use the latest here and bump others later in ENG-3102

This revision is now accepted and ready to land.Mar 31 2023, 4:14 AM
Closed by commit rCOMMf30a02df6cdd: [identity] bump aws-config and aws-sdk-dynamodb crate versions (authored by varun). · Explain WhyMar 31 2023, 12:21 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMf30a02df6cdd: [identity] bump aws-config and aws-sdk-dynamodb crate versions.

Revision Contents
Changeset List

PathSize
services/
identity/
5 lines
src/
2 lines

Diff 24522

View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/database.rs

Loading...