[desktop] Extract showNewNotification function
ClosedPublic
Actions

Authored by michal on Apr 3 2023, 4:53 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMad0a9c58dfed: [desktop] Extract showNewNotification function

Summary

This code will be used by both Windows and macOS so I'm extracting it into a separate function.

Test Plan

Check if macOS notifications still work.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Apr 3 2023, 4:53 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 3 2023, 4:53 AM

michal added a child revision: D7287: [desktop] Handle windows notifications.Apr 3 2023, 4:57 AM

Harbormaster completed remote builds in B17938: Diff 24570.Apr 3 2023, 5:09 AM

michal requested review of this revision.Apr 3 2023, 5:09 AM

kamil accepted this revision.Apr 4 2023, 1:26 AM

kamil added inline comments.

desktop/src/push-notifications.js
21 ↗	(On Diff #24570)	can you annotate types of function arguments here?

This revision is now accepted and ready to land.Apr 4 2023, 1:26 AM

Added types

Harbormaster completed remote builds in B18008: Diff 24669.Apr 5 2023, 9:43 AM

Closed by commit rCOMMad0a9c58dfed: [desktop] Extract showNewNotification function (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyApr 11 2023, 3:20 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMad0a9c58dfed: [desktop] Extract showNewNotification function.

Revision Contents
Changeset List

Path

Size

desktop/

src/

push-notifications.js

38 lines

Diff 24669

View Options

desktop/src/push-notifications.js

[desktop] Extract showNewNotification functionClosedPublicActions