As explained in the inline comment, we want viewer to be false so the message is left-aligned and the username is displayed (feedback from Ted design wise)

This is because we don't want to 'double render' the username and date for messages that will already have them rendered based on the conditions in the ComposedMessage component and the Message component

This is because we don't want to 'double render' the username, since we're rendering Message, which renders ComposedMessage, the component sometimes displays the username inherently based on some conditions.

I separated this into it's own component because we need to re-use PinnedMessage when the user wants to view a list of all pinned messages for the thread in a separate modal.

Makes sense, I will take a brief look at whether it makes sense to do it now or postpone it like you suggest, and after make a Linear task to not lose track of it

Yeah, I thought this would be safe since we optimistically create the message as is, but I can add a follow-up / update this diff to change the behavior accordingly if needed

From what I experienced, since we're essentially rendering the Message component within the modal, without the context, the invariant here gets triggered.

In terms of moving the context above the modal, I couldn't find a good place to otherwise put it when going through the component hierarchy in dev tools (the Fragment representing the modal). I'm definitely open to suggestions though if you feel like it can be changed like you suggest

Yeah, we always want to display the username for a pinned message. This condition is basically so we don't "double render" the username since ComposedMessage already will render a username in chat under a certain condition: https://github.com/CommE2E/comm/blob/master/web/chat/composed-message.react.js#L208-L209

Yeah I can change this to a margin instead, may make maintaining it easier as well