[keyserver] Move deep link handling logic to a separate function
ClosedPublic
Actions

Authored by tomek on Apr 5 2023, 3:36 AM.

Details

Reviewers

bartek
kamil

Commits

rCOMMec2bb59f8d40: [keyserver] Move deep link handling logic to a separate function

Summary

This function grows and now it makes sense to extract it.
Depends on D7271

Test Plan

Checked on a physical iPhone that clicking this link can open the App Store. It's just one branch of the logic, but this diff is only about moving the code, so it should suffice.

Diff Detail

Repository

rCOMM Comm

Branch

invite2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Apr 5 2023, 3:36 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 5 2023, 3:36 AM

Harbormaster completed remote builds in B17995: Diff 24652.Apr 5 2023, 3:52 AM

tomek requested review of this revision.Apr 5 2023, 3:52 AM

tomek added a child revision: D7312: [keyserver] Create a page with invite link.Apr 5 2023, 5:54 AM

tomek planned changes to this revision.Apr 5 2023, 5:58 AM

Move function to website responders - we're going to use some functions from that file.

Harbormaster completed remote builds in B18000: Diff 24658.Apr 5 2023, 6:30 AM

kamil accepted this revision.Apr 6 2023, 1:45 AM

This revision is now accepted and ready to land.Apr 6 2023, 1:45 AM

Closed by commit rCOMMec2bb59f8d40: [keyserver] Move deep link handling logic to a separate function (authored by tomek). · Explain WhyApr 12 2023, 6:47 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMec2bb59f8d40: [keyserver] Move deep link handling logic to a separate function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

keyserver.js

24 lines

responders/

deep-link-responder.js

28 lines

Diff 24652

View Options

keyserver/src/keyserver.js