[web] Only update badge when connected
ClosedPublic
Actions

Authored by michal on Apr 6 2023, 7:32 AM.

Details

Reviewers

kamil
inka
ashoat

Commits

rCOMM17642df70d65: [web] Only update badge when connected

Summary

Part of ENG-3350.
Changed the tab title/ icon badge logic on web to update only when websocket is connected (otherwise the unreadCound could be outdated). Additionaly we update the badge immediately when connecting to the websocket. The logic is identical to the one on native (native/push/push-handler.react.js:226-232);

Depends on D7327

Test Plan

Open the web app in the browser and in the desktop app (without notifs). Check if sending a message updated the tab title (browser)/ badge (desktop), and reading it removes them.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Apr 6 2023, 7:32 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 6 2023, 7:32 AM

Move file

Harbormaster completed remote builds in B18048: Diff 24729.Apr 6 2023, 7:49 AM

Harbormaster completed remote builds in B18050: Diff 24731.Apr 6 2023, 7:54 AM

michal requested review of this revision.Apr 6 2023, 7:54 AM

ashoat accepted this revision.Apr 6 2023, 11:06 AM

ashoat added inline comments.

web/push-notif/badge-handler.react.js
13 ↗	(On Diff #24731)	I actually think we should initialize this to `undefined`. That way, on the first run if `connection.status === 'connected'`, it will update the badge count