Page MenuHomePhabricator
Differential D7337

[lib][native] Deprecate unshimMessageStore
ClosedPublic
Actions

Authored by ashoat on Apr 6 2023, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 11:21 AM
Unknown Object (File)
Mar 17 2025, 4:58 PM
Unknown Object (File)
Feb 28 2025, 1:13 PM
Unknown Object (File)
Feb 28 2025, 1:13 PM
Unknown Object (File)
Feb 28 2025, 1:13 PM
Unknown Object (File)
Feb 27 2025, 3:22 PM
Unknown Object (File)
Feb 25 2025, 4:28 PM
Unknown Object (File)
Feb 15 2025, 2:37 PM
View All 88 Files
Subscribers
tomek

Details

Reviewers
atul
kamil
bartek
Commits
rCOMMbd05e90ad757: [lib][native] Deprecate unshimMessageStore
Summary

I want to make it clear that this function shouldn't be used. It doesn't work in the new SQLite world.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
native/
redux/
13 lines

Diff 24764

View Options

lib/shared/unshim-utils.js

#include "BlobItem.h" #include "BlobItem.h"
#include "Constants.h" #include "Constants.h"
#include <glog/logging.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string BlobItem::FIELD_BLOB_HASH = "blobHash"; const std::string BlobItem::FIELD_BLOB_HASH = "blobHash";
const std::string BlobItem::FIELD_S3_PATH = "s3Path"; const std::string BlobItem::FIELD_S3_PATH = "s3Path";
const std::string BlobItem::FIELD_CREATED = "created"; const std::string BlobItem::FIELD_CREATED = "created";
std::string BlobItem::tableName = BLOB_TABLE_NAME; std::string BlobItem::tableName = BLOB_TABLE_NAME;
BlobItem::BlobItem( BlobItem::BlobItem(
const std::string blobHash, const std::string blobHash,
const S3Path s3Path, const S3Path s3Path,
uint64_t created) uint64_t created)
: blobHash(blobHash), s3Path(s3Path), created(created) { : blobHash(blobHash), s3Path(s3Path), created(created) {
this->validate(); this->validate();
} }
BlobItem::BlobItem(const AttributeValues &itemFromDB) { BlobItem::BlobItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void BlobItem::validate() const { void BlobItem::validate() const {
LOG(INFO) << "[BlobItem::validate]";
if (!this->blobHash.size()) { if (!this->blobHash.size()) {
throw std::runtime_error("blobHash empty"); throw std::runtime_error("blobHash empty");
} }
this->s3Path.validate(); this->s3Path.validate();
} }
void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) { void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) {
LOG(INFO) << "[BlobItem::assignItemFromDatabase]";
try { try {
this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS(); this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS();
LOG(INFO) << "[BlobItem::assignItemFromDatabase] blob hash "
<< this->blobHash;
this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS()); this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS());
this->created = std::stoll( this->created = std::stoll(
std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str()); std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str());
} catch (std::logic_error &e) { } catch (std::logic_error &e) {
throw std::runtime_error( throw std::runtime_error(
"invalid blob item provided, " + std::string(e.what())); "invalid blob item provided, " + std::string(e.what()));
} }
this->validate(); this->validate();
Show All 29 Lines
View Options

native/redux/persist.js

#include "BlobItem.h" #include "BlobItem.h"
#include "Constants.h" #include "Constants.h"
#include <glog/logging.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string BlobItem::FIELD_BLOB_HASH = "blobHash"; const std::string BlobItem::FIELD_BLOB_HASH = "blobHash";
const std::string BlobItem::FIELD_S3_PATH = "s3Path"; const std::string BlobItem::FIELD_S3_PATH = "s3Path";
const std::string BlobItem::FIELD_CREATED = "created"; const std::string BlobItem::FIELD_CREATED = "created";
std::string BlobItem::tableName = BLOB_TABLE_NAME; std::string BlobItem::tableName = BLOB_TABLE_NAME;
BlobItem::BlobItem( BlobItem::BlobItem(
const std::string blobHash, const std::string blobHash,
const S3Path s3Path, const S3Path s3Path,
uint64_t created) uint64_t created)
: blobHash(blobHash), s3Path(s3Path), created(created) { : blobHash(blobHash), s3Path(s3Path), created(created) {
this->validate(); this->validate();
} }
BlobItem::BlobItem(const AttributeValues &itemFromDB) { BlobItem::BlobItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void BlobItem::validate() const { void BlobItem::validate() const {
LOG(INFO) << "[BlobItem::validate]";
if (!this->blobHash.size()) { if (!this->blobHash.size()) {
throw std::runtime_error("blobHash empty"); throw std::runtime_error("blobHash empty");
} }
this->s3Path.validate(); this->s3Path.validate();
} }
void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) { void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) {
LOG(INFO) << "[BlobItem::assignItemFromDatabase]";
try { try {
this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS(); this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS();
LOG(INFO) << "[BlobItem::assignItemFromDatabase] blob hash "
<< this->blobHash;
this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS()); this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS());
this->created = std::stoll( this->created = std::stoll(
std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str()); std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str());
} catch (std::logic_error &e) { } catch (std::logic_error &e) {
throw std::runtime_error( throw std::runtime_error(
"invalid blob item provided, " + std::string(e.what())); "invalid blob item provided, " + std::string(e.what()));
} }
this->validate(); this->validate();
Show All 29 Lines