Page MenuHomePhabricator

[lib][landing][web] Use getCommConfig to get API keys for Webpack builds
ClosedPublic

Authored by ashoat on Apr 7 2023, 10:58 AM.
Tags
None
Referenced Files
F2196363: D7357.diff
Fri, Jul 5, 12:31 PM
F2195577: D7357.diff
Fri, Jul 5, 10:46 AM
Unknown Object (File)
Mon, Jun 10, 4:58 PM
Unknown Object (File)
Wed, Jun 5, 1:48 PM
Unknown Object (File)
Wed, Jun 5, 1:48 PM
Unknown Object (File)
Wed, Jun 5, 1:48 PM
Unknown Object (File)
May 30 2024, 1:27 AM
Unknown Object (File)
May 30 2024, 1:27 AM
Subscribers

Details

Summary

Linear task: ENG-3229.

Now that we're using getCommConfig, these API keys can be specified with JSON files in keyserver/secrets instead of requiring patching package.json files with env var declarations.

Depends on D7354

Test Plan
  1. I created a valid keyserver/secrets/alchemy.json file
  2. I added a console.log to print the value of alchemyKey from getConfigs in lib/webpack/shared.cjs
  3. I made sure that it printed the right value when called from landing and web, in both dev and prod modes

I also made sure to set the corresponding env var on my production keyserver.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable