Page MenuHomePhabricator
Differential D7390

[services] remove identity.proto
ClosedPublic
Actions

Authored by varun on Apr 11 2023, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 1:40 AM
Unknown Object (File)
Sun, May 5, 8:08 PM
Unknown Object (File)
Wed, May 1, 7:13 PM
Unknown Object (File)
Wed, May 1, 4:41 PM
Unknown Object (File)
Wed, May 1, 4:40 PM
Unknown Object (File)
Apr 16 2024, 3:21 AM
Unknown Object (File)
Apr 15 2024, 9:54 PM
Unknown Object (File)
Apr 15 2024, 12:54 AM
View All 65 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
• jon
Commits
rCOMMaa8c28720430: [services] remove identity.proto
Summary

we don't need this file anymore. removed all related code from the identity service, rust-node-addon, Dockerfiles, etc.

Test Plan

built all the cargo projects that depend on this .proto file

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 11 2023, 2:12 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptApr 11 2023, 2:12 PM
Harbormaster completed remote builds in B18259: Diff 25017.Apr 11 2023, 2:27 PM
varun requested review of this revision.Apr 11 2023, 2:27 PM
• jon accepted this revision.Apr 11 2023, 3:06 PM

otherwise looks fine

.github/workflows/identity_tests.yml
8 ↗(On Diff #25017)

I really dislike glob'ing over a single file

This revision is now accepted and ready to land.Apr 11 2023, 3:06 PM
varun added inline comments.Apr 11 2023, 3:12 PM
.github/workflows/identity_tests.yml
8 ↗(On Diff #25017)

yeah was trying to future-proof in case we end up in a world with multiple protos again, but i doubt that will happen so will apply your feedback

Closed by commit rCOMMaa8c28720430: [services] remove identity.proto (authored by varun). · Explain WhyApr 11 2023, 3:13 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMaa8c28720430: [services] remove identity.proto.
• jon mentioned this in D8366: [Keyserver/rust] Add device login and register.Jul 4 2023, 1:08 PM

Revision Contents
Changeset List

PathSize
.github/
workflows/
2 lines
keyserver/
addons/
rust-node-addon/
5 lines
src/
identity_client/
84 lines
services/
identity/
1 line
5 lines
src/
21 lines
8 lines
service/
shared/
protos/
_generated/

Diff 25018

View Options

.github/workflows/identity_tests.yml

Loading...
View Options

keyserver/addons/rust-node-addon/build.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/compare_users.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/delete_user.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/login_user.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Loading...
View Options

keyserver/addons/rust-node-addon/src/identity_client/update_user.rs

Loading...
View Options

services/identity/Dockerfile

Loading...
View Options

services/identity/build.rs

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

services/identity/src/pake_grpc.rs

Loading...
View Options

services/identity/src/service.rs

Loading...
View Options

services/identity/src/service/login.rs

Loading...
View Options

services/identity/src/service/registration.rs

Loading...
View Options

services/identity/src/service/update.rs

Loading...
View Options

shared/protos/_generated/identity.grpc.pb.h

Loading...
View Options

shared/protos/_generated/identity.grpc.pb.cc

Loading...
View Options

shared/protos/_generated/identity.pb.h

Loading...
View Options

shared/protos/_generated/identity.pb.cc

Loading...
View Options

shared/protos/identity.proto

Loading...