Differential D7459

[native] have actionsheet pop up on press when editing avatar
ClosedPublic
Actions

Authored by ginsu on Apr 16 2023, 11:29 PM.

Tags

None

Referenced Files

	F3295881: D7459.diff
	Sat, Nov 16, 11:36 PM

	Unknown Object (File)
	Thu, Oct 31, 9:13 PM

	Unknown Object (File)
	Thu, Oct 31, 9:13 PM

	Unknown Object (File)
	Thu, Oct 31, 9:13 PM

	Unknown Object (File)
	Thu, Oct 31, 9:04 PM

	Unknown Object (File)
	Sat, Oct 26, 2:54 PM

	Unknown Object (File)
	Oct 13 2024, 1:09 AM

	Unknown Object (File)
	Oct 1 2024, 7:11 AM

View All 54 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM1ecd401b99bc: [native] have actionsheet pop up on press when editing avatar

Summary

When the user now presses on a user or thread avatar in the profile or thread settings, an action sheet popups displaying various options for editing an avatar. For this diff the only option is the emoji avatar edit flow; however, diffs further down this stack will introduce other edit options

Test Plan

Please watch the demo videos:

iOS:

Android:

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 16 2023, 11:29 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 16 2023, 11:29 PM

ginsu edited the summary of this revision. (Show Details)Apr 16 2023, 11:35 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu attached a referenced file: F489878: Screen Recording 2023-04-16 at 7.05.04 PM.mov. (Show Details)

ginsu attached a referenced file: F489877: Screen Recording 2023-04-16 at 6.58.09 PM.mov. (Show Details)

Harbormaster completed remote builds in B18396: Diff 25204.Apr 16 2023, 11:47 PM

ginsu requested review of this revision.Apr 16 2023, 11:47 PM

ginsu added a child revision: D7460: [native] update save avatar hooks to accept all types of avatars.Apr 16 2023, 11:47 PM

ashoat accepted this revision.Apr 17 2023, 4:55 AM

This revision is now accepted and ready to land.Apr 17 2023, 4:55 AM

Closed by commit rCOMM1ecd401b99bc: [native] have actionsheet pop up on press when editing avatar (authored by ginsu). · Explain WhyApr 17 2023, 8:34 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM1ecd401b99bc: [native] have actionsheet pop up on press when editing avatar.

Revision Contents
Changeset List

Path

Size

native/

components/

edit-avatar.react.js

78 lines

Diff 25204

native/components/edit-avatar.react.js

Loading...