Page MenuHomePhabricator
Differential D7508

[native] Move `UserAvatar` "inside" `EditUserAvatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 11:14 PM
Unknown Object (File)
Tue, Mar 25, 10:26 AM
Unknown Object (File)
Mar 6 2025, 12:17 PM
Unknown Object (File)
Mar 6 2025, 12:16 PM
Unknown Object (File)
Mar 6 2025, 12:16 PM
Unknown Object (File)
Feb 27 2025, 3:38 AM
Unknown Object (File)
Feb 24 2025, 5:24 PM
Unknown Object (File)
Feb 24 2025, 5:24 PM
View All 92 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM912799556ba0: [native] Move `UserAvatar` "inside" `EditUserAvatar`
Summary

Intead of passing in UserAvatar as React.Node as a prop to EditUserAvatar, we pass ?userID as a prop and render UserAvatar "inside" EditUserAvatar.

Depends on D7507

Test Plan

Things continue to look and work as expected:

860d94.png (1×882 px, 805 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
avatars/
7 lines
profile/
9 lines

Diff 25354

View Options

native/avatars/edit-user-avatar.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

native/profile/profile-screen.react.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm