Page MenuHomePhabricator
Differential D7506

[native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 16, 7:22 AM
Unknown Object (File)
Tue, Jul 16, 7:21 AM
Unknown Object (File)
Tue, Jul 16, 7:21 AM
Unknown Object (File)
Tue, Jul 16, 7:19 AM
Unknown Object (File)
Wed, Jul 3, 12:36 AM
Unknown Object (File)
Mon, Jul 1, 11:08 AM
Unknown Object (File)
Sun, Jun 30, 5:21 AM
Unknown Object (File)
Wed, Jun 26, 10:36 AM
View All 47 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM45d2bc435f8a: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
Summary

Pulling out some more logic that's in common between EditUserAvatar and EditThreadAvatar.

NOTE: One more quick refactor to tidy up editAvatarOptions and then we're gooing to move UserAvatar and ThreadAvatar "inside" Edit*Avatar components instead of just passing in React.Node.
Test Plan

Action sheet appears as it did previously + ESLint + Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
avatars/
57 lines
50 lines
50 lines

Diff 25353

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...