Page MenuHomePhabricator
Differential D7506

[native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 5:03 PM
Unknown Object (File)
Thu, Mar 20, 9:02 PM
Unknown Object (File)
Sat, Mar 8, 5:50 PM
Unknown Object (File)
Thu, Mar 6, 12:16 PM
Unknown Object (File)
Mon, Feb 24, 5:24 PM
Unknown Object (File)
Mon, Feb 24, 5:24 PM
Unknown Object (File)
Feb 23 2025, 6:13 PM
Unknown Object (File)
Feb 21 2025, 1:15 AM
View All 89 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM45d2bc435f8a: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
Summary

Pulling out some more logic that's in common between EditUserAvatar and EditThreadAvatar.

NOTE: One more quick refactor to tidy up editAvatarOptions and then we're gooing to move UserAvatar and ThreadAvatar "inside" Edit*Avatar components instead of just passing in React.Node.
Test Plan

Action sheet appears as it did previously + ESLint + Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
avatars/
57 lines
50 lines
50 lines

Diff 25353

View Options

native/avatars/avatar-hooks.js

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/avatars/edit-thread-avatar.react.js

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.
View Options

native/avatars/edit-user-avatar.react.js

  • This file was moved to services/lib/src/DatabaseEntitiesTools.h.