Details

Reviewers

ashoat
ginsu

Commits

rCOMM683fb7914ed5: [native] Introduce `useRemoveUserAvatar` hook

Summary

We introduce the useRemoveUserAvatar hook so we can unset the user avatar. Will introduce something similar for threads momentarily.

Depends on D7511

Test Plan

Able to clear user avatar:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 19 2023, 2:48 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 19 2023, 2:48 AM

atul published this revision for review.Apr 19 2023, 2:50 AM

atul edited the summary of this revision. (Show Details)

atul edited the test plan for this revision. (Show Details)

atul added a parent revision: D7511: [native] Introduce naive `useSelectFromGalleryAndUpdateThreadAvatar` hook.

atul added inline comments.Apr 19 2023, 3:01 AM

native/avatars/avatar-hooks.js
327–333 ↗	(On Diff #25320)	Here's how it looks on Android:

atul attached a referenced file: F494908: Screenshot_1681873252.png. (Show Details)Apr 19 2023, 3:01 AM

Harbormaster completed remote builds in B18489: Diff 25320.Apr 19 2023, 3:05 AM

atul added a child revision: D7513: [native] Introduce `useRemoveThreadAvatar` hook.Apr 19 2023, 3:19 AM

ashoat accepted this revision.Apr 19 2023, 1:20 PM

ashoat added inline comments.

native/avatars/avatar-hooks.js
327–333 ↗	(On Diff #25320)	Thanks for including this

This revision is now accepted and ready to land.Apr 19 2023, 1:20 PM

Closed by commit rCOMM683fb7914ed5: [native] Introduce `useRemoveUserAvatar` hook. · Explain WhyApr 19 2023, 4:28 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM683fb7914ed5: [native] Introduce `useRemoveUserAvatar` hook.

[native] Introduce `useRemoveUserAvatar` hook
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 25359

native/avatars/avatar-hooks.js

native/avatars/edit-user-avatar.react.js

[native] Introduce `useRemoveUserAvatar` hookClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25359

native/avatars/avatar-hooks.js

native/avatars/edit-user-avatar.react.js

[native] Introduce `useRemoveUserAvatar` hook
ClosedPublic
Actions

Revision Contents
Changeset List