[native] Use CommUtilsModule for encrypted media
ClosedPublic
Actions

Authored by bartek on Apr 19 2023, 2:01 AM.

Details

Reviewers

marcin
atul

Commits

rCOMM5938924b6f42: [native] Use CommUtilsModule for encrypted media

Summary

This diff replaces slow JS file <-> ArrayBuffer operations with the C++ ones from CommUtilsModule.

This resolves ENG-3408.

Depends on D7486

Test Plan

Cleared media cache.
Sent encrypted media (both photo and video) from native. Was able to decrypt and view the messages.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 19 2023, 2:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 19 2023, 2:01 AM

bartek published this revision for review.Apr 19 2023, 2:16 AM

Harbormaster completed remote builds in B18493: Diff 25324.Apr 19 2023, 2:20 AM

atul accepted this revision.Apr 19 2023, 9:45 AM

This revision is now accepted and ready to land.Apr 19 2023, 9:45 AM

Rebase before landing

Harbormaster completed remote builds in B18604: Diff 25481.Apr 21 2023, 1:02 AM

Closed by commit rCOMM5938924b6f42: [native] Use CommUtilsModule for encrypted media (authored by bartek). · Explain WhyApr 21 2023, 2:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5938924b6f42: [native] Use CommUtilsModule for encrypted media.

Revision Contents
Changeset List

Path

Size

native/

media/

encryption-utils.js

34 lines

Diff 25481

View Options

native/media/encryption-utils.js

[native] Use CommUtilsModule for encrypted mediaClosedPublicActions