[native] Install CommUtils JSI module
ClosedPublic
Actions

Authored by bartek on Apr 14 2023, 5:36 AM.

Details

Reviewers

atul
marcin
kamil

Commits

rCOMM4859024da48d: [native] Install CommUtils JSI module

Summary

Added code to install the CommUtilsModule JSI module for both Android and iOS

Depends on D7451

Test Plan

Both platforms compile.
Replaced the dummy jsi::Value::undefined() returns in CommUtilsModule with e.g. jsi::Value(42) and verified that these are callable from JS.
CommCoreModule remains unaffected and still works the same way as previously

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 14 2023, 5:36 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 14 2023, 5:36 AM

Harbormaster failed remote builds in B18369: Diff 25163!Apr 14 2023, 5:54 AM

Rebase

Harbormaster completed remote builds in B18371: Diff 25165.Apr 14 2023, 6:15 AM

bartek published this revision for review.Apr 14 2023, 8:01 AM

Don't have a ton of experience here but makes sense, would be good to amend test plan to make sure that we can call functions in CommCoreModule as before

This revision is now accepted and ready to land.Apr 17 2023, 6:36 AM

In D7452#221895, @atul wrote:

Don't have a ton of experience here but makes sense, would be good to amend test plan to make sure that we can call functions in CommCoreModule as before

Checked, works as expected

bartek added a child revision: D7485: [native][utils-module] Implement file r/w operations.Apr 18 2023, 8:07 AM

Rebase before landing

Harbormaster completed remote builds in B18601: Diff 25478.Apr 21 2023, 12:59 AM

Closed by commit rCOMM4859024da48d: [native] Install CommUtils JSI module (authored by bartek). · Explain WhyApr 21 2023, 2:20 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4859024da48d: [native] Install CommUtils JSI module.