Wouldn't it be more simple / readable to handle this at the callsite for selectFromGalleryAndUpdateUserAvatar? Eg. like this:

const [userAvatarUpdateInProgress, setUserAvatarUpdateInProgress] = React.useState(false);
const updateCallback = React.useCallback(async () => {
  setUserAvatarUpdateInProgress(true);
  try {
    const result = await selectFromGalleryAndUpdateUserAvatar(params);
  } finally {
    setUserAvatarUpdateInProgress(false);
  }
}. [selectFromGalleryAndUpdateUserAvatar, params]);

It will lead to a little bit of copy-paste, but might be worth it for the improved readability / simplicity. What do you think?

In D7527#223357, @ashoat wrote:

Wouldn't it be more simple / readable to handle this at the callsite for selectFromGalleryAndUpdateUserAvatar? Eg. like this:

const [userAvatarUpdateInProgress, setUserAvatarUpdateInProgress] = React.useState(false);
const updateCallback = React.useCallback(async () => {
  setUserAvatarUpdateInProgress(true);
  try {
    const result = await selectFromGalleryAndUpdateUserAvatar(params);
  } finally {
    setUserAvatarUpdateInProgress(false);
  }
}. [selectFromGalleryAndUpdateUserAvatar, params]);

It will lead to a little bit of copy-paste, but might be worth it for the improved readability / simplicity. What do you think?

If it was just selectFromGalleryAndUpdateUserAvatar I agree that this solution would be cleaner.

However, we also will need to handle useRemoveUserAvatar and captureImageAndUpdateUserAvatar... and so having a wrapper in EditUserAvatar and EditThreadAvatar for each of those could get repetitive.

Personally prefer that all of the complexity regarding progress is pushed down to the hooks and that they expose a simple isLoading boolean that can be handled from the EditUserAvatar and EditThreadAvatar components. I'm trying to keep as much complexity and logic as possible in the hooks for now to make consolidation of common logic easier once things are shippable.

Also worth noting that even after we await selectFromGalleryAndUpdateUserAvatar that dispatchActionPromise(..., updateUserAvatarCall(imageAvatarUpdateRequest)) will almost definitely still be "loading", so we'd need to have logic to handle that in the Edit[User/Thread]Avatar components.