Page MenuHomePhabricator
Differential D7627

[native] move setting ens avatar logic from avatar hooks to edit user avatar provider
ClosedPublic
Actions

Authored by ginsu on Apr 25 2023, 2:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 3:15 AM
Unknown Object (File)
Sun, Oct 27, 12:38 AM
Unknown Object (File)
Sun, Oct 27, 12:38 AM
Unknown Object (File)
Sun, Oct 27, 12:38 AM
Unknown Object (File)
Sun, Oct 27, 12:38 AM
Unknown Object (File)
Sun, Oct 27, 12:38 AM
Unknown Object (File)
Sun, Oct 27, 12:35 AM
Unknown Object (File)
Fri, Oct 25, 7:16 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMe256381ac6ad: [native] move setting ens avatar logic from avatar hooks to edit user avatar…
Summary

This diff moves the logic for setting an ens avatar from the avatar hooks to the new edit user avatar provider

Depends on D7626

Test Plan

Able to set ens avatar with expected behavior with and the loading state returns the correct values when the set avatar request is happening

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 25 2023, 2:24 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 2:24 PM
ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 2:28 PM
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7626: [native] introduce edit user avatar provider scaffolding.
ginsu added a child revision: D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.Apr 25 2023, 2:41 PM
Harbormaster completed remote builds in B18773: Diff 25720.Apr 25 2023, 2:43 PM
ginsu requested review of this revision.Apr 25 2023, 2:43 PM
ashoat accepted this revision.Apr 25 2023, 6:03 PM

Please address inline comment before landing

native/avatars/edit-user-avatar-provider.react.js
65 ↗(On Diff #25720)

We should still throw here so we emit the right action. Otherwise you're implicitly returning undefined, which is an anti-pattern

(We should add an ESLint rule for this... just created ENG-3776 to track)

This revision is now accepted and ready to land.Apr 25 2023, 6:03 PM
ginsu updated this revision to Diff 25744.Apr 26 2023, 3:00 AM

address comments

Harbormaster completed remote builds in B18788: Diff 25744.Apr 26 2023, 3:18 AM
ginsu updated this revision to Diff 25866.Apr 27 2023, 10:18 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 27 2023, 10:28 AM
Closed by commit rCOMMe256381ac6ad: [native] move setting ens avatar logic from avatar hooks to edit user avatar… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe256381ac6ad: [native] move setting ens avatar logic from avatar hooks to edit user avatar….
Harbormaster completed remote builds in B18886: Diff 25866.Apr 27 2023, 10:35 AM

Revision Contents
Changeset List

Diff 25869

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-user-avatar-provider.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...