Page MenuHomePhabricator
Differential D7622

[native] move navigate to emoji user avatar creation function to be within edit user avatar
ClosedPublic
Actions

Authored by ginsu on Apr 25 2023, 1:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 4:58 PM
Unknown Object (File)
Fri, Dec 13, 3:24 PM
Unknown Object (File)
Thu, Dec 12, 3:09 PM
Unknown Object (File)
Nov 24 2024, 5:41 AM
Unknown Object (File)
Nov 24 2024, 5:41 AM
Unknown Object (File)
Nov 24 2024, 5:41 AM
Unknown Object (File)
Nov 24 2024, 5:41 AM
Unknown Object (File)
Nov 24 2024, 5:41 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMa73447d07684: [native] move navigate to emoji user avatar creation function to be within edit…
Summary

Small cleanup diff, I figured it would be better to have this logic within EditUserAvatar than in the ProfileScreen

Depends on D7621

Test Plan

flow still able to navigate to the user emoji avatar creation screen

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 25 2023, 1:07 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 1:07 PM
ginsu added reviewers: ashoat, atul.Apr 25 2023, 1:08 PM
ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 1:12 PM
ginsu added a parent revision: D7621: [native] move selecting from gallery logic from avatar hooks to edit user avatar provider.
Harbormaster completed remote builds in B18764: Diff 25709.Apr 25 2023, 1:26 PM
ginsu requested review of this revision.Apr 25 2023, 1:26 PM
ashoat accepted this revision.Apr 25 2023, 1:33 PM

Address inline comment before landing

native/avatars/edit-user-avatar.react.js
46 ↗(On Diff #25709)

We only need navigation.navigate in here

This revision is now accepted and ready to land.Apr 25 2023, 1:33 PM
ginsu updated this revision to Diff 25746.Apr 26 2023, 3:05 AM

address comments

Harbormaster completed remote builds in B18790: Diff 25746.Apr 26 2023, 3:22 AM
ginsu added a child revision: D7628: [native] improve factoring out redundant logic for saving an image user avatar.Apr 26 2023, 3:30 AM
ginsu updated this revision to Diff 25873.Apr 27 2023, 11:09 AM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 27 2023, 11:13 AM
Closed by commit rCOMMa73447d07684: [native] move navigate to emoji user avatar creation function to be within edit… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMa73447d07684: [native] move navigate to emoji user avatar creation function to be within edit….
Harbormaster completed remote builds in B18889: Diff 25873.Apr 27 2023, 11:27 AM

Revision Contents
Changeset List

PathSize
native/
avatars/
14 lines
profile/
10 lines

Diff 25876

View Options

native/avatars/edit-user-avatar.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...