[native] introduce edit user avatar provider scaffolding
ClosedPublic
Actions

Authored by ginsu on Apr 25 2023, 1:58 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMbeeb0016468e: [native] introduce edit user avatar provider scaffolding

Summary

First step in breaking down D7621. In this diff I introduce the Edit User Avatar provider and moved the remove user avatar functionality from the avatar-hooks to this provider. Future diffs will bring the other edit avatar functionality over to this provider

Depends on D7573

Test Plan

Able to remove an avatar and the behavior is to be expected with removing an avatar and the loading state returns the correct values when the set avatar request was happening

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 25 2023, 1:58 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 25 2023, 1:58 PM

ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 1:58 PM

ginsu added a parent revision: D7573: [native] convert useSelectFromGallery to selectFromGallery.

ginsu added inline comments.Apr 25 2023, 2:01 PM

native/avatars/edit-user-avatar-provider.react.js
45–48 ↗	(On Diff #25715)	This may seem unnecessary but the very next diff will add another condition that will make this block necessary
native/avatars/edit-user-avatar.react.js
46–49 ↗	(On Diff #25715)	Eventually we will be able to get rid of this when all the loading logic is put into the edit user avatar provider (a future diff)

ginsu edited the summary of this revision. (Show Details)Apr 25 2023, 2:07 PM

Harbormaster completed remote builds in B18768: Diff 25715.Apr 25 2023, 2:16 PM

ginsu requested review of this revision.Apr 25 2023, 2:16 PM

ginsu added reviewers: ashoat, atul.Apr 25 2023, 2:23 PM

ginsu added inline comments.Apr 25 2023, 2:28 PM

native/avatars/edit-user-avatar-provider.react.js
45–48 ↗	(On Diff #25715)	Edit: not the very next diff but the diff after the next diff

ginsu added a child revision: D7627: [native] move setting ens avatar logic from avatar hooks to edit user avatar provider.Apr 25 2023, 2:28 PM

ginsu added inline comments.Apr 25 2023, 2:43 PM

native/avatars/edit-user-avatar-provider.react.js
45–48 ↗	(On Diff #25715)	D7621

Small fixes

native/avatars/edit-user-avatar-provider.react.js
45–48 ↗	(On Diff #25715)	There's no point memoizing a boolean, especially when it's such a simple calculation (even in D7621). Your intuition for memoization is off... ask me about this in the office tomorrow. (Please remove the `React.useMemo`)
61 ↗	(On Diff #25715)	We should still throw here so we emit an `UPDATE_USER_AVATAR_FAILED` instead of `UPDATE_USER_AVATAR_SUCCESS`