To avoid overloaded terms, use content instead of identity when
describing the main olm account.
Details
Details
Gates pass
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jonringer/refactor-identity-to-content (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Only looked at .proto changes
| shared/protos/identity_client.proto | ||
|---|---|---|
| 78 ↗ | (On Diff #25861) | I don't think this should've been renamed. Actually, the fact that you accidentally renamed this is a strong signal that our renaming is a good idea See your comment below:
IdentityKeyInfo is a good name to cover both of these. It was confusing before, when "Identity" was overloaded to mean two things. But now that it only means one thing, I think it's a good name to keep |
Comment Actions
Please make sure you're going through your changes carefully, and not just submitting a find-replace diff. The term "identity" is used in many places, and not all of those places correspond to the notif vs. content dichotomy
| shared/protos/identity_client.proto | ||
|---|---|---|
| 86 ↗ | (On Diff #25906) | What does it mean to correlate a wallet with the "content" of a device? |
| shared/protos/identity_client.proto | ||
|---|---|---|
| 86 ↗ | (On Diff #25906) | rephrased this, as it was ambiguous what "identity of a device" meant originally |
Comment Actions
Accepting for the .proto changes. Can't exactly speak for completeness on the Rust side of things, but the changes that have been made seem okay