Paths

Table of Contentst

Differential D7676

[native] make handlePhotoCapture return mixed instead of void
ClosedPublic
Actions

Authored by ginsu on Apr 27 2023, 1:24 PM.

Tags

None

Referenced Files

	F2167748: D7676.id25887.diff
	Tue, Jul 2, 7:07 AM

	Unknown Object (File)
	Sun, Jun 30, 11:15 PM

	Unknown Object (File)
	Sun, Jun 30, 12:08 AM

	Unknown Object (File)
	Tue, Jun 18, 7:18 AM

	Unknown Object (File)
	Fri, Jun 14, 2:08 AM

	Unknown Object (File)
	Thu, Jun 13, 11:11 PM

	Unknown Object (File)
	Wed, Jun 12, 2:12 PM

	Unknown Object (File)
	Thu, Jun 6, 12:07 PM

View All 69 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM87e0e3e2ddd4: [native] make handlePhotoCapture return mixed instead of void

Summary

Based on feedback I got in D7624 we should change the type of handlePhotoCapture so that we can make CameraModal even more permissive

Test Plan

flow and double checked to make sure that the camera modal still has the same expected behavior

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 27 2023, 1:24 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 27 2023, 1:24 PM

ginsu published this revision for review.Apr 27 2023, 1:25 PM

ginsu added a child revision: D7624: [native] introduce user avatar camera modal.

ginsu added reviewers: ashoat, atul.

ashoat accepted this revision.Apr 27 2023, 1:27 PM

This revision is now accepted and ready to land.Apr 27 2023, 1:27 PM

Harbormaster completed remote builds in B18898: Diff 25887.Apr 27 2023, 1:42 PM

Closed by commit rCOMM87e0e3e2ddd4: [native] make handlePhotoCapture return mixed instead of void (authored by ginsu). · Explain WhyApr 27 2023, 1:43 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM87e0e3e2ddd4: [native] make handlePhotoCapture return mixed instead of void.

Revision Contents
Changeset List

Path

Size

native/

media/

camera-modal.react.js

2 lines

Diff 25892

native/media/camera-modal.react.js

Loading...