In this diff I introduce the edit thread avatar provider and moved the remove user avatar functionality from the avatar-hooks to this provider. Future diffs will bring the other edit avatar functionality over to this provider.
Depends on D7624
Details
Details
- Reviewers
ashoat atul - Commits
- rCOMMfc5e55e7e858: [native] introduce edit thread avatar provider
Able to remove an avatar and the behavior is to be expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/avatars/edit-thread-avatar-provider.react.js | ||
|---|---|---|
| 39 ↗ | (On Diff #25755) | I initially tried using an invariant to make sure the NavContext was set; however, this caused the app to crash so a work around that I felt good with is to set the activeThreadID to an empty string whenever a user is not actively in a thread. I don't think this should cause any issues with this provider, since you can only edit a thread avatar whenever you are actively in a thread, so activeThreadID should always be set in those cases. |
| native/avatars/edit-thread-avatar-provider.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #25898) | This was a change I had to do. Previously we would get threadID from the hook parameter, but now that we don't have the hook anymore we need to get threadID from this callback parameter |
| native/avatars/edit-thread-avatar.react.js | ||
|---|---|---|
| 38–40 ↗ | (On Diff #25898) | Will simplify this |