[native] have saving thread avatar loaders only appear for thread being updated
ClosedPublic
Actions

Authored by ginsu on Apr 27 2023, 3:47 PM.

Details

Reviewers

atul
ashoat

Commits

rCOMMd3224971ec9e: [native] have saving thread avatar loaders only appear for thread being updated

Summary

Added the activeThreadID/threadID to the thread settings loading status selector custom keys. This fixes the issue where if we update a thread avatar the loaders would be shared and shown across different threads.

Depends on D7629

Test Plan

Tested that the loader only appeared in the thread avatar I was updating:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 27 2023, 3:47 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 27 2023, 3:47 PM

ginsu edited the summary of this revision. (Show Details)Apr 27 2023, 3:48 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, ashoat.

ginsu added a parent revision: D7629: [native] introduce edit thread avatar provider.

ginsu attached a referenced file: F513823: Screen Recording 2023-04-27 at 12.44.11 AM.mov. (Show Details)

ginsu added inline comments.

native/avatars/edit-thread-avatar-provider.react.js
39 ↗	(On Diff #25900)	I initially tried using an invariant to make sure the `NavContext` was set; however, this caused the app to crash so a work around that I felt good with is to set the `activeThreadID` to an empty string whenever a user is not actively in a thread. I don't think this should cause any issues with this provider, since you can only edit a thread avatar whenever you are actively in a thread, so `activeThreadID` should always be set in those cases.