This diff adds the following new icons to the CommIcon pack: edit-filled, link_plus-outline, unpin-outline and pin-outline. These changes were copy and pasted from files given to me by Ted.
I also added the icons to our dropbox
Details
Details
- Reviewers
atul ashoat - Commits
- rCOMMe32fedf8b34d: [lib/native] add more icons to comm icon pack
Tested every icon to make sure there were no regressions, and here are the screenshots for the new icons
edit-filled
link_plus-outline
unpin-outline
pin-outline
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Does the sizing look right? Can't really tell from the images from the Test Plan, but as long as things looked right during your testing.
Comment Actions
It'd also be good to test on native to make sure the generated TTF glyphs look as expected.
Comment Actions
Does the sizing look right? Can't really tell from the images from the Test Plan, but as long as things looked right during your testing.
I actually just double checked using the inspector tool, and noticed that these new icons are actually a tad bit smaller, will have ted fix this and send me some new icons
It'd also be good to test on native to make sure the generated TTF glyphs look as expected.
The screenshots in the test plan are all from native
Comment Actions
https://linear.app/comm/issue/ENG-3855/make-commicons-all-uniform-at-16x16px
Discussed this with @ashoat and Ted, but we are going to land this for now to unblock @rohan and the task above is a follow up task to make all our comm icons uniform at 16x16px
Comment Actions
Realized that I misnamed the edit-filled icon in the description/test plan but @kuba you should be good now!