This differential implements updater that can use olm session to encrypt data.
Details
- Apply those changes to NotificationService.mm: https://gist.github.com/marcinwasowicz/0a43950fb202f03b3c5b92fe17dd5272
- Build the app
- Log in
- Pull from the db cookie id of the currently logged in user.
- Apply those changes to the send.js in the keyserver: https://gist.github.com/marcinwasowicz/9bc13a92310a9b91a59d73a2557b62a9
- Add your cookie id.
- Send the notif.
- Ensure it is displayed and examine the logs
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
11 ↗ | (On Diff #26405) | In this particular case I think it is not wise to introduce such a strict constraint on a retry number. |
12 ↗ | (On Diff #26405) | My intention to use smaller constant was that we expect olm sessions to be updated more frequently than olm account. Additionally there will be more concurrent updates at the same time. Therefore it is wise to wait shorter between subsequent retries. |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
11 ↗ | (On Diff #26405) | Can you create a follow-up task for this? |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
11 ↗ | (On Diff #26405) | I would rather do it before landing this stack. I wouldn't expect this change to take more than 15-30 minutes. |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
18 ↗ | (On Diff #26405) | Doesn't need to be $ReadOnly |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
1 ↗ | (On Diff #26636) | Can we add a newline here? |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
18 ↗ | (On Diff #26650) | If we're going to do encryption of all fields in one pass, should we simplify this function so that it only takes one message? |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
18 ↗ | (On Diff #26650) | My opinion on this is that it would be better to have this function taking one message if it was designed to deal specifically with notifications. However signature of this function indicates that it is supposed to work with both types of sessions. I am not sure what kind of scenarios are going to utilise content session, but if they need possibility to encrypt a couple of messages at once if is beneficial to have such API. |
keyserver/src/updaters/olm-session-updater.js | ||
---|---|---|
18 ↗ | (On Diff #26650) | Okay, we can leave as-is |