Page MenuHomePhabricator

Populate keyserver_olm_accounts table
ClosedPublic

Authored by marcin on Apr 21 2023, 4:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 4:13 AM
Unknown Object (File)
Tue, Nov 26, 6:01 PM
Unknown Object (File)
Mon, Nov 11, 7:43 AM
Unknown Object (File)
Thu, Nov 7, 10:50 AM
Unknown Object (File)
Oct 27 2024, 11:19 PM
Unknown Object (File)
Oct 17 2024, 7:24 PM
Unknown Object (File)
Oct 17 2024, 7:24 PM
Unknown Object (File)
Oct 17 2024, 7:24 PM
Subscribers

Details

Summary

This differential populates keyserver_olm_account table with primary and notifications olm accounts. Methods to create pickled olm account and unpickle pickled olm account are implemented as well. Pickled olm account creation implementation is take from the following diff:
https://phab.comm.dev/D3209. It might be usefull for reviewers to take a look at this diff to potentially avoid questions that have already been answered.

Test Plan

Repeat test plan for the parent diff. Additionally using database inspection tool of choice examine the content of keyserver_olm_accounts table. Ensure there are two different accounts there that one of which has is_primary set to TRUE, while the other set to FASLE.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
keyserver/src/database/migration-config.js
374–381 ↗(On Diff #25516)

Can we keep lines to 80 chars?

Also we can reduce the indentation of the VALUES lines and below

keyserver/src/database/setup-db.js
459–465 ↗(On Diff #25516)

Same feedback as above

This revision is now accepted and ready to land.Apr 21 2023, 7:09 AM

Please address my feedback before landing... repeating it from last review

keyserver/src/database/migration-config.js
378–379 ↗(On Diff #25592)

Lines are still too long. Please keep lines to a max of 80 chars

keyserver/src/database/setup-db.js
461–464 ↗(On Diff #25592)

Once again, please keep all lines to a max of 80 chars

Rename is_primary to is_content

Please address line length issues before your next update!! This is my third time repeating this on this diff!!

Comply to line length convention

Rebase to fix invalid migrations versions

Rebase to fix an SQL syntax error

Rebase master before landing

This revision was automatically updated to reflect the committed changes.