Details

Reviewers

tomek
atul
bartek
inka
• jon
ashoat

Commits

rCOMM0b462245d313: Populate keyserver_olm_accounts table

Summary

This differential populates keyserver_olm_account table with primary and notifications olm accounts. Methods to create pickled olm account and unpickle pickled olm account are implemented as well. Pickled olm account creation implementation is take from the following diff:
https://phab.comm.dev/D3209. It might be usefull for reviewers to take a look at this diff to potentially avoid questions that have already been answered.

Test Plan

Repeat test plan for the parent diff. Additionally using database inspection tool of choice examine the content of keyserver_olm_accounts table. Ensure there are two different accounts there that one of which has is_primary set to TRUE, while the other set to FASLE.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Apr 21 2023, 4:32 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 21 2023, 4:32 AM

marcin added a parent revision: D7560: Add table for keyserver olm accounts.Apr 21 2023, 4:32 AM

marcin added a reviewer: • jon.Apr 21 2023, 4:36 AM

Harbormaster completed remote builds in B18626: Diff 25516.Apr 21 2023, 4:49 AM

marcin requested review of this revision.Apr 21 2023, 4:49 AM

ashoat accepted this revision.Apr 21 2023, 7:09 AM

ashoat added inline comments.

keyserver/src/database/migration-config.js
374–381 ↗	(On Diff #25516)	Can we keep lines to 80 chars? Also we can reduce the indentation of the `VALUES` lines and below
keyserver/src/database/setup-db.js
459–465 ↗	(On Diff #25516)	Same feedback as above

This revision is now accepted and ready to land.Apr 21 2023, 7:09 AM

marcin added a child revision: D7568: Implement fetcher and updater for olm accounts on the keyserver.Apr 21 2023, 8:09 AM

Rebase. Fix formatting

Harbormaster completed remote builds in B18686: Diff 25592.Apr 24 2023, 2:58 AM

Please address my feedback before landing... repeating it from last review

keyserver/src/database/migration-config.js
378–379	Lines are still too long. Please keep lines to a max of 80 chars
keyserver/src/database/setup-db.js
461–464	Once again, please keep all lines to a max of 80 chars