Page MenuHomePhabricator
Differential D7901

[web] Add hook to generate placeholder image
ClosedPublic
Actions

Authored by bartek on May 21 2023, 7:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 12:41 PM
Unknown Object (File)
Wed, Apr 24, 10:24 AM
Unknown Object (File)
Sun, Apr 14, 3:15 PM
Unknown Object (File)
Sun, Apr 14, 3:15 PM
Unknown Object (File)
Sun, Apr 14, 3:15 PM
Unknown Object (File)
Sun, Apr 14, 3:15 PM
Unknown Object (File)
Sun, Apr 14, 3:09 PM
Unknown Object (File)
Feb 23 2024, 9:03 PM
View All 23 Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
ginsu
inka
Commits
rCOMM83822bdaeeb7: [web] Add hook to generate placeholder image
Summary

This diff adds a hool that generates placeholder data URL from given thumbhash string. It also decrypts the thumbhash if encryption key is provided.

The operation is synchronous for non-encrypted thumbhash and asynchronous for encrypted ones.

Depends on D7900

Test Plan

Tested together with the next diff.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 21 2023, 7:57 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptMay 21 2023, 7:58 AM
bartek added a child revision: D7902: [web] Display thumbhash in chat.May 21 2023, 8:02 AM
bartek published this revision for review.May 21 2023, 8:08 AM
Harbormaster completed remote builds in B19547: Diff 26728.May 21 2023, 8:15 AM
ashoat accepted this revision.May 22 2023, 9:42 AM
ashoat added inline comments.
web/media/media-utils.js
3

Nit – we mostly use React.useState and React.useEffect instead of importing these individually, but to be honest that convention probably doesn't really matter

217

Not sure this comment is adding much value

This revision is now accepted and ready to land.May 22 2023, 9:42 AM
bartek added a child revision: D7946: [web] Add loadable video component.May 23 2023, 7:29 AM
bartek removed a child revision: D7902: [web] Display thumbhash in chat.May 23 2023, 7:38 AM
bartek updated this revision to Diff 26897.May 23 2023, 7:50 AM

Use React imports, remove comment

Harbormaster completed remote builds in B19689: Diff 26897.May 23 2023, 8:07 AM
bartek removed a child revision: D7946: [web] Add loadable video component.May 23 2023, 11:57 PM
bartek removed a parent revision: D7900: [web] Add thumbhash to encrypted media, fix spinner.May 24 2023, 12:01 AM
bartek added a child revision: D7902: [web] Display thumbhash in chat.May 24 2023, 12:04 AM
ashoat mentioned this in D7946: [web] Add loadable video component.May 24 2023, 9:00 AM
Closed by commit rCOMM83822bdaeeb7: [web] Add hook to generate placeholder image (authored by bartek). · Explain WhyMay 24 2023, 11:19 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM83822bdaeeb7: [web] Add hook to generate placeholder image.

Revision Contents
Changeset List

PathSize
web/
media/
16 lines
40 lines

Diff 26728

View Options

web/media/encryption-utils.js

Loading...
View Options

web/media/media-utils.js

Loading...