Page MenuHomePhabricator
Differential D7949

[web] Parse invite link secret
ClosedPublic
Actions

Authored by tomek on May 23 2023, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 8:05 PM
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 11:00 PM
Unknown Object (File)
Sat, Mar 1, 10:58 PM
Unknown Object (File)
Sat, Mar 1, 10:39 PM
Unknown Object (File)
Mon, Feb 24, 3:43 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMM8fe47a7ba889: [web] Parse invite link secret
Summary

After user clicks invite link, we're checking if the url contains a secret and save it in redux if that's the case.

Depends on D7948

Test Plan

Open localhost:3000/invite/abc123 and check if navInfo in redux contains inviteSecret: "abc123".

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 23 2023, 9:46 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 23 2023, 9:46 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 23 2023, 10:04 AM
Harbormaster failed remote builds in B19700: Diff 26913!
tomek updated this revision to Diff 26957.May 24 2023, 3:48 AM

Rebase

Harbormaster completed remote builds in B19719: Diff 26957.May 24 2023, 4:06 AM
tomek requested review of this revision.May 24 2023, 4:06 AM
tomek updated this revision to Diff 26995.May 24 2023, 9:00 AM

Make invite secret nullable

Harbormaster completed remote builds in B19737: Diff 26995.May 24 2023, 9:20 AM
tomek added a child revision: D7957: [web] Create a modal where invite link can be accepted.May 24 2023, 9:27 AM
inka accepted this revision.May 25 2023, 12:30 AM
This revision is now accepted and ready to land.May 25 2023, 12:30 AM
Closed by commit rCOMM8fe47a7ba889: [web] Parse invite link secret (authored by tomek). · Explain WhyMay 25 2023, 7:30 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM8fe47a7ba889: [web] Parse invite link secret.

Revision Contents
Changeset List

PathSize
lib/
utils/
9 lines
web/
types/
2 lines
4 lines

Diff 27057

View Options

lib/utils/url-utils.js

// @flow // @flow
import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMDeleteEntryOperation } from '../../types/dm-ops.js'; import type { DMDeleteEntryOperation } from '../../types/dm-ops.js';
import type { ThickRawEntryInfo } from '../../types/entry-types.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { EntryUpdateInfo } from '../../types/update-types.js'; import type { EntryUpdateInfo } from '../../types/update-types.js';
import { dateFromString } from '../../utils/date-utils.js'; import { dateFromString } from '../../utils/date-utils.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) { function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
const { threadID, creatorID, time, entryID, entryDate, prevText } = const { threadID, creatorID, time, entryID, entryDate, prevText } =
Show All 9 Linesfunction createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
}; };
} }
const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({ const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({
notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => { notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => {
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] }; return { messageDatas: [messageData] };
}, },
processDMOperation: async (dmOperation: DMDeleteEntryOperation) => { processDMOperation: async (
dmOperation: DMDeleteEntryOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { const {
threadID, threadID,
creatorID, creatorID,
time, time,
creationTime, creationTime,
entryID, entryID,
entryDate: dateString, entryDate: dateString,
prevText, prevText,
messageID, messageID,
} = dmOperation; } = dmOperation;
const rawEntryInfo = utilities.entryInfos[entryID];
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [ const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID), rawMessageInfoFromMessageData(messageData, messageID),
]; ];
invariant(rawEntryInfo?.thick, 'Entry thread should be thick');
const timestamp = rawEntryInfo.lastUpdatedTime;
if (timestamp > time) {
return {
rawMessageInfos,
updateInfos: [],
};
}
const date = dateFromString(dateString); const date = dateFromString(dateString);
const rawEntryInfo: ThickRawEntryInfo = { const rawEntryInfoToUpdate = {
id: entryID, id: entryID,
threadID, threadID,
text: prevText, text: prevText,
year: date.getFullYear(), year: date.getFullYear(),
month: date.getMonth() + 1, month: date.getMonth() + 1,
day: date.getDate(), day: date.getDate(),
creationTime, creationTime,
creatorID, creatorID,
thick: true, thick: true,
deleted: true, deleted: true,
lastUpdatedTime: time, lastUpdatedTime: time,
}; };
const entryUpdateInfo: EntryUpdateInfo = { const entryUpdateInfo: EntryUpdateInfo = {
entryInfo: rawEntryInfo, entryInfo: rawEntryInfoToUpdate,
type: updateTypes.UPDATE_ENTRY, type: updateTypes.UPDATE_ENTRY,
id: uuid.v4(), id: uuid.v4(),
time, time,
}; };
return { return {
rawMessageInfos, rawMessageInfos,
updateInfos: [entryUpdateInfo], updateInfos: [entryUpdateInfo],
Show All 22 Lines
View Options

web/types/nav-types.js

// @flow // @flow
import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMDeleteEntryOperation } from '../../types/dm-ops.js'; import type { DMDeleteEntryOperation } from '../../types/dm-ops.js';
import type { ThickRawEntryInfo } from '../../types/entry-types.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { EntryUpdateInfo } from '../../types/update-types.js'; import type { EntryUpdateInfo } from '../../types/update-types.js';
import { dateFromString } from '../../utils/date-utils.js'; import { dateFromString } from '../../utils/date-utils.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) { function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
const { threadID, creatorID, time, entryID, entryDate, prevText } = const { threadID, creatorID, time, entryID, entryDate, prevText } =
Show All 9 Linesfunction createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
}; };
} }
const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({ const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({
notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => { notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => {
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] }; return { messageDatas: [messageData] };
}, },
processDMOperation: async (dmOperation: DMDeleteEntryOperation) => { processDMOperation: async (
dmOperation: DMDeleteEntryOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { const {
threadID, threadID,
creatorID, creatorID,
time, time,
creationTime, creationTime,
entryID, entryID,
entryDate: dateString, entryDate: dateString,
prevText, prevText,
messageID, messageID,
} = dmOperation; } = dmOperation;
const rawEntryInfo = utilities.entryInfos[entryID];
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [ const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID), rawMessageInfoFromMessageData(messageData, messageID),
]; ];
invariant(rawEntryInfo?.thick, 'Entry thread should be thick');
const timestamp = rawEntryInfo.lastUpdatedTime;
if (timestamp > time) {
return {
rawMessageInfos,
updateInfos: [],
};
}
const date = dateFromString(dateString); const date = dateFromString(dateString);
const rawEntryInfo: ThickRawEntryInfo = { const rawEntryInfoToUpdate = {
id: entryID, id: entryID,
threadID, threadID,
text: prevText, text: prevText,
year: date.getFullYear(), year: date.getFullYear(),
month: date.getMonth() + 1, month: date.getMonth() + 1,
day: date.getDate(), day: date.getDate(),
creationTime, creationTime,
creatorID, creatorID,
thick: true, thick: true,
deleted: true, deleted: true,
lastUpdatedTime: time, lastUpdatedTime: time,
}; };
const entryUpdateInfo: EntryUpdateInfo = { const entryUpdateInfo: EntryUpdateInfo = {
entryInfo: rawEntryInfo, entryInfo: rawEntryInfoToUpdate,
type: updateTypes.UPDATE_ENTRY, type: updateTypes.UPDATE_ENTRY,
id: uuid.v4(), id: uuid.v4(),
time, time,
}; };
return { return {
rawMessageInfos, rawMessageInfos,
updateInfos: [entryUpdateInfo], updateInfos: [entryUpdateInfo],
Show All 22 Lines
View Options

web/url-utils.js

// @flow // @flow
import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMDeleteEntryOperation } from '../../types/dm-ops.js'; import type { DMDeleteEntryOperation } from '../../types/dm-ops.js';
import type { ThickRawEntryInfo } from '../../types/entry-types.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { EntryUpdateInfo } from '../../types/update-types.js'; import type { EntryUpdateInfo } from '../../types/update-types.js';
import { dateFromString } from '../../utils/date-utils.js'; import { dateFromString } from '../../utils/date-utils.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) { function createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
const { threadID, creatorID, time, entryID, entryDate, prevText } = const { threadID, creatorID, time, entryID, entryDate, prevText } =
Show All 9 Linesfunction createMessageDataFromDMOperation(dmOperation: DMDeleteEntryOperation) {
}; };
} }
const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({ const deleteEntrySpec: DMOperationSpec<DMDeleteEntryOperation> = Object.freeze({
notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => { notificationsCreationData: async (dmOperation: DMDeleteEntryOperation) => {
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
return { messageDatas: [messageData] }; return { messageDatas: [messageData] };
}, },
processDMOperation: async (dmOperation: DMDeleteEntryOperation) => { processDMOperation: async (
dmOperation: DMDeleteEntryOperation,
viewerID: string,
utilities: ProcessDMOperationUtilities,
) => {
const { const {
threadID, threadID,
creatorID, creatorID,
time, time,
creationTime, creationTime,
entryID, entryID,
entryDate: dateString, entryDate: dateString,
prevText, prevText,
messageID, messageID,
} = dmOperation; } = dmOperation;
const rawEntryInfo = utilities.entryInfos[entryID];
const messageData = createMessageDataFromDMOperation(dmOperation); const messageData = createMessageDataFromDMOperation(dmOperation);
const rawMessageInfos = [ const rawMessageInfos = [
rawMessageInfoFromMessageData(messageData, messageID), rawMessageInfoFromMessageData(messageData, messageID),
]; ];
invariant(rawEntryInfo?.thick, 'Entry thread should be thick');
const timestamp = rawEntryInfo.lastUpdatedTime;
if (timestamp > time) {
return {
rawMessageInfos,
updateInfos: [],
};
}
const date = dateFromString(dateString); const date = dateFromString(dateString);
const rawEntryInfo: ThickRawEntryInfo = { const rawEntryInfoToUpdate = {
id: entryID, id: entryID,
threadID, threadID,
text: prevText, text: prevText,
year: date.getFullYear(), year: date.getFullYear(),
month: date.getMonth() + 1, month: date.getMonth() + 1,
day: date.getDate(), day: date.getDate(),
creationTime, creationTime,
creatorID, creatorID,
thick: true, thick: true,
deleted: true, deleted: true,
lastUpdatedTime: time, lastUpdatedTime: time,
}; };
const entryUpdateInfo: EntryUpdateInfo = { const entryUpdateInfo: EntryUpdateInfo = {
entryInfo: rawEntryInfo, entryInfo: rawEntryInfoToUpdate,
type: updateTypes.UPDATE_ENTRY, type: updateTypes.UPDATE_ENTRY,
id: uuid.v4(), id: uuid.v4(),
time, time,
}; };
return { return {
rawMessageInfos, rawMessageInfos,
updateInfos: [entryUpdateInfo], updateInfos: [entryUpdateInfo],
Show All 22 Lines