Details

Reviewers

ashoat
ginsu

Commits

rCOMMa647d70cdef4: [native] Introduce `CommunityCreationNavigator`

Summary

Heavily inspired by RegistrationNavigator, this diff introduces CommunityCreationNavigator. This navigator will "handle" the screens of the community creation flow. Specifically the community configuration screen and the optional "Add members" screen.

WARNING: Please let me know if this is the wrong approach. My understanding is that because we have > 1 screen in sequence as part of our flow we should create a new navigation stack. HOWEVER, I have a very very limited understanding of navigation on native, so please correct me if that assumption is incorrect and I should approach this differently.

Test Plan

Set isCommunityCreationButtonEnabled to true.
Open community drawer and press "Create community."
Observe that CommunityConfiguration is displayed (by looking at screen "title").

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-05-23 at 16.26.55.png (2×1 px, 86 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 23 2023, 1:19 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 23 2023, 1:19 PM

atul added a child revision: D7951: [native] Add keyserver label to `CommunityConfiguration`.May 23 2023, 1:20 PM

atul edited the test plan for this revision. (Show Details)May 23 2023, 1:28 PM

Harbormaster completed remote builds in B19701: Diff 26914.May 23 2023, 1:40 PM

atul requested review of this revision.May 23 2023, 1:40 PM

High-level approach is great, but some comments below

native/community-creation/community-creation-navigator.react.js
31 ↗	(On Diff #26914)	I'm not sure since I don't have the link to the Figma designs handy, but if the title is different for different screens, this might be something you want to specify to `CommunityConfiguration` directly: <CommunityCreation.Screen name={CommunityConfigurationRouteName} component={CommunityConfiguration} options={{ headerTitle: 'Create a community' }} /> (Memoized of course)
32 ↗	(On Diff #26914)	I use `white` directly in the registration flow, but that flow is built for dark mode only. I think you'll need to call `useColors` in `CommunityCreationNavigator`, and construct `screenOptions` with the appropriate color there
native/navigation/root-navigator.react.js
207 ↗	(On Diff #26914)	Why include `disableGesturesScreenOptions` here? Feels like it would be better with gestures enabled

This revision now requires changes to proceed.May 23 2023, 2:16 PM

rebase

address feedback

atul marked 3 inline comments as done.May 24 2023, 7:18 AM

atul added inline comments.

native/community-creation/community-creation-navigator.react.js
31 ↗	(On Diff #26914)	Thanks for catching that, made the change
32 ↗	(On Diff #26914)	Updated to use `colors.panelForegroundLabel`
native/navigation/root-navigator.react.js
207 ↗	(On Diff #26914)	No good reason, removed that