Add TextInput field to CommunityConfiguration for user to enter desired community name.
Depends on D7951
Details
Details
Appears as expected, "functionality" will be tested with subsequent diffs.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- arcpatch-D7952 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
The placeholder color you're using is super bright. Can you link to designs? Feels like it might be best to stick with what RegistrationTextInput does for consistency
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #26916) | The way you're mixing components from different places is weird, but I think it's good that components are being reused in general. Can you make a Linear task to rename / move these general-purpose components somewhere later? (I did check and they're all using the panel family of colors, which is good for compatibility) |
| 53 ↗ | (On Diff #26916) | Should we use RegistrationTextInput to maximize reuse / consistency? It uses panelSecondaryForegroundBorder instead of textInputPlaceholder, which is shadesBlack70 in dark mode instead of shadesWhite60. Feels like a pretty significant difference... did Ted really design these interfaces with such a different placeholder color? |
| native/community-creation/community-configuration.react.js | ||
|---|---|---|
| 50 ↗ | (On Diff #26916) | Ah yeah intended to leave a comment here flagging this, also reusing RegistrationContainer and RegistrationContentContainer here. Was going to try to generalize naming + possibly move to /components later in the stack. Will create a Linear task to track: https://linear.app/comm/issue/ENG-3929/renamemove-components-used-in-communityconfiguration-to-make-more |
| 53 ↗ | (On Diff #26916) | We could, but the RegistrationTextInput component looks a lot different than the TextInput in the designs (which more closely resemble inputs in ThreadSettings). There were no placeholder colors specified in the designs, so I just browsed Figma until I found a text input w/ a similar background and placeholder and copied that. In hindsight I probably should've copied the link down somewhere to reference it.... What I can do now is use the placeholder colors from RegistrationTextInput and then create a Linear task in the DES workspace to follow up w/ @ted when he's back? |
Comment Actions
What I can do now is use the placeholder colors from RegistrationTextInput and then create a Linear task in the DES workspace to follow up w/ @ted when he's back?
Added comment to Linear on existing issue regarding form/input styling consistency: https://linear.app/comm/issue/DES-89/ensure-consistent-forminput-styling-throughout-designs#comment-e61d4350