Differential D7955

[native] Change border radius of filled-in input fields
ClosedPublic
Actions

Authored by inka on May 24 2023, 4:31 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 25, 9:17 AM

	Unknown Object (File)
	Fri, Apr 5, 10:01 AM

	Unknown Object (File)
	Fri, Apr 5, 10:01 AM

	Unknown Object (File)
	Fri, Apr 5, 9:59 AM

	Unknown Object (File)
	Fri, Apr 5, 9:55 AM

	Unknown Object (File)
	Mar 6 2024, 9:52 AM

	Unknown Object (File)
	Feb 20 2024, 7:04 PM

	Unknown Object (File)
	Feb 20 2024, 4:35 PM

View All 21 Files

Subscribers

Details

Reviewers

• kuba
michal
ginsu

Commits

rCOMM874faf41d97a: [native] Change border radius of filled-in input fields

Summary

issue: https://linear.app/comm/issue/ENG-3867/update-mobile-filled-in-input-fields
We want all filled in input fields to have a border radius of 8.

Test Plan

Checked that the radius of the input bar is now 8px.
I went through the app and checked for any filled-in input fields that don't have a border radius of 8. I went throught the code and checked all places using TextInput (and code using that code if
the style was not specified there, and so on).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 24 2023, 4:31 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 24 2023, 4:31 AM

Harbormaster completed remote builds in B19721: Diff 26977.May 24 2023, 4:50 AM

inka requested review of this revision.May 24 2023, 4:50 AM

michal accepted this revision.May 25 2023, 2:05 AM

This revision is now accepted and ready to land.May 25 2023, 2:05 AM

Closed by commit rCOMM874faf41d97a: [native] Change border radius of filled-in input fields (authored by • InkaSokolowska). · Explain WhyJun 1 2023, 2:09 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM874faf41d97a: [native] Change border radius of filled-in input fields.

Revision Contents
Changeset List

Path

Size

native/

chat/

chat-input-bar.react.js

2 lines

Diff 27338

native/chat/chat-input-bar.react.js

Loading...