Details

Reviewers

ginsu
atul

Commits

rCOMM649d3964fd77: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar

Summary

In the last diff I removed useSaveUserAvatar, but after comparing the Alert code I think the old code was better.

This diff migrates us to using that Alert code across all callsites.

Depends on D8018

Test Plan

Flow / careful reading, make sure app still runs

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 30 2023, 12:38 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 30 2023, 12:38 AM

ashoat added a child revision: D8020: [native] Replace removeThreadAvatar with generic setThreadAvatar.May 30 2023, 12:39 AM

ashoat mentioned this in D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.

ashoat mentioned this in D8018: [native] Replace generic useSaveUserAvatar with new generic setUserAvatar.May 30 2023, 12:49 AM

Harbormaster completed remote builds in B19879: Diff 27235.May 30 2023, 12:56 AM

ashoat requested review of this revision.May 30 2023, 12:56 AM

atul accepted this revision.May 30 2023, 4:13 PM

This revision is now accepted and ready to land.May 30 2023, 4:13 PM

atul added inline comments.May 30 2023, 4:15 PM

native/avatars/edit-user-avatar-provider.react.js
41 ↗	(On Diff #27235)	very minor, but personally would prefer if the function name began with a verb eg `displayFailureAlert` or `showFailureAlert`

displayFailureAlert

This revision was landed with ongoing or failed builds.May 30 2023, 7:09 PM

Closed by commit rCOMM649d3964fd77: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM649d3964fd77: [native] Use Alert from old useSaveUserAvatar in new setUserAvatar.

ashoat mentioned this in rCOMM5d343f2ba01b: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.

Harbormaster completed remote builds in B19916: Diff 27278.May 30 2023, 7:24 PM

[native] Use Alert from old useSaveUserAvatar in new setUserAvatar
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 27282

native/avatars/edit-user-avatar-provider.react.js

[native] Use Alert from old useSaveUserAvatar in new setUserAvatarClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27282

native/avatars/edit-user-avatar-provider.react.js

[native] Use Alert from old useSaveUserAvatar in new setUserAvatar
ClosedPublic
Actions

Revision Contents
Changeset List