Page MenuHomePhabricator

[native] Use Alert from old useSaveUserAvatar in new setUserAvatar
ClosedPublic

Authored by ashoat on May 29 2023, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 1:04 AM
Unknown Object (File)
Feb 11 2024, 1:03 AM
Unknown Object (File)
Feb 11 2024, 1:03 AM
Unknown Object (File)
Feb 11 2024, 12:08 AM
Unknown Object (File)
Feb 10 2024, 10:44 PM
Unknown Object (File)
Dec 31 2023, 11:01 AM
Unknown Object (File)
Dec 16 2023, 9:56 PM
Unknown Object (File)
Dec 16 2023, 7:51 PM
Subscribers

Details

Summary

In the last diff I removed useSaveUserAvatar, but after comparing the Alert code I think the old code was better.

This diff migrates us to using that Alert code across all callsites.

Depends on D8018

Test Plan

Flow / careful reading, make sure app still runs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 30 2023, 9:13 AM
native/avatars/edit-user-avatar-provider.react.js
41 ↗(On Diff #27235)

very minor, but personally would prefer if the function name began with a verb

eg displayFailureAlert or showFailureAlert