Page MenuHomePhabricator

[native] Make EmojiThreadAvatarCreation work with activeThreadSelector
ClosedPublic

Authored by ashoat on May 29 2023, 5:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 1:59 PM
Unknown Object (File)
Oct 27 2024, 8:19 AM
Unknown Object (File)
Oct 23 2024, 5:27 AM
Unknown Object (File)
Oct 22 2024, 2:57 PM
Unknown Object (File)
Oct 14 2024, 11:18 PM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Unknown Object (File)
Sep 29 2024, 4:46 AM
Subscribers

Details

Summary

In D8021, we changing how our loading status worked. Before that the custom key name was not thread specific, but afterwards it is.

In the new system, for EditThreadAvatarProvider to know which threadID to look up, it calls activeThreadSelector on the nav state. For this to work, we need two things to be true:

  1. The React Navigation route needs to be in routeNames in route-names.js
  2. The React Navigation route params should have a field called threadInfo

This diff makes both changes so that the loading detection works

Depends on D8022

Test Plan

I added an artificial delay on the keyserver side and confirmed that the loading spinner appears currently now (which was a regression introduced in D8021)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable