Paths

Table of Contentst

Differential D8021

[native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar
ClosedPublic
Actions

Authored by ashoat on May 30 2023, 12:40 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

ginsu
atul

Commits

rCOMM894ce8c8bac0: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar

Summary

Unifying codepaths here, similar to what D8018 did for user avatars.

In a later diff I'll need to make sure that activeThreadSelector works with the EmojiThreadAvatarCreation screen.

Depends on D8020

Test Plan

Test setting emoji avatar for thread from iOS simulator

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 30 2023, 12:40 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 30 2023, 12:40 AM

ashoat added a child revision: D8022: [native] Use Alert from old useSaveThreadAvatar in new setThreadAvatar.May 30 2023, 12:41 AM

ashoat mentioned this in D8023: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.May 30 2023, 12:45 AM

ashoat added inline comments.May 30 2023, 12:47 AM

native/utils/avatar-utils.js
3–5 ↗	(On Diff #27237)	This file can now be deleted once ENG-3413 is complete. That will leave us with at least two other `avatar-utils.js` files in the codebase (`lib/shared` and `lib/utils`)
41–48 ↗	(On Diff #27237)	I bring this back in D8022

Harbormaster returned this revision to the author for changes because remote builds failed.May 30 2023, 12:55 AM

Harbormaster failed remote builds in B19881: Diff 27237!

Rebase to fix ESLint error

ashoat added inline comments.May 30 2023, 1:02 AM

native/utils/avatar-utils.js
3–5 ↗	(On Diff #27241)	This file can now be deleted once ENG-3413 is complete. That will leave us with at least two other `avatar-utils.js` files in the codebase (`lib/shared` and `lib/utils`)
41–48 ↗	(On Diff #27241)	I bring this back in D8022

Harbormaster completed remote builds in B19885: Diff 27241.May 30 2023, 1:19 AM

ashoat requested review of this revision.May 30 2023, 1:19 AM

atul accepted this revision.May 30 2023, 4:29 PM

This revision is now accepted and ready to land.May 30 2023, 4:29 PM

Closed by commit rCOMM894ce8c8bac0: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar. · Explain WhyMay 30 2023, 7:09 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM894ce8c8bac0: [native] Replace generic useSaveThreadAvatar with new generic setThreadAvatar.

ashoat mentioned this in rCOMMce10be74ff99: [native] Make EmojiThreadAvatarCreation work with activeThreadSelector.

Revision Contents
Changeset List

Path

Size

native/

chat/

settings/

emoji-thread-avatar-creation.react.js

36 lines

utils/

avatar-utils.js

58 lines

Diff 27284

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...

native/utils/avatar-utils.js

Loading...