[native] Introduce RegistrationMode in EditUserAvatarProvider
ClosedPublic
Actions

Authored by ashoat on May 31 2023, 1:05 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM3c9aefcd99b3: [native] Introduce RegistrationMode in EditUserAvatarProvider

Summary

A consumer of the EditUserAvatarContext will be able to call setRegistrationMode to override what happens when an avatar is successfully selected.

This will allow the registration flow to get the avatar info without needing to change much other code.

Test Plan

This was tested in combination with the rest of the stack. I tested:

ENS flow, both when user has an ENS avatar and when they don't
Setting an emoji avatar
Setting an image avatar via camera
Setting an image avatar via media library
Tested avatar update flow after being logged in to make sure I didn't regress anything

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 31 2023, 1:05 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 31 2023, 1:05 PM

ashoat added a child revision: D8042: [native] Replace savedEmojiAvatarSelector with savedEmojiAvatarFunc.May 31 2023, 1:09 PM

Harbormaster completed remote builds in B19932: Diff 27319.May 31 2023, 1:26 PM

ashoat requested review of this revision.May 31 2023, 1:26 PM

ashoat added inline comments.May 31 2023, 1:27 PM

native/avatars/edit-user-avatar-provider.react.js
108 ↗	(On Diff #27319)	In D8017, I made `setUserAvatar` wait until the keyserver call completed before returning. Doing the same thing here since it allows callers to eg. display a loading spinner while the operation is happening. Current callers don't actually `await` the promise anyways