Page MenuHomePhabricator

[native] Introduce avatarData state to hold pending avatar in AvatarSelection
ClosedPublic

Authored by ashoat on May 31 2023, 1:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 9:10 PM
Unknown Object (File)
Thu, Apr 4, 9:10 PM
Unknown Object (File)
Thu, Apr 4, 9:09 PM
Unknown Object (File)
Thu, Apr 4, 9:01 PM
Unknown Object (File)
Feb 26 2024, 9:24 PM
Unknown Object (File)
Feb 26 2024, 9:24 PM
Unknown Object (File)
Feb 26 2024, 9:24 PM
Unknown Object (File)
Feb 26 2024, 9:24 PM
Subscribers

Details

Summary

This diff "introduces" this state (it was previously introduced, but was never updated), and adds code for updating it.

We now see updates of the avatar in AvatarSelection reflected in the UserAvatar rendered by EditUserAvatar.

Depends on D8047

Test Plan

This was tested in combination with the rest of the stack. I tested:

  1. ENS flow, both when user has an ENS avatar and when they don't
  2. Setting an emoji avatar
  3. Setting an image avatar via camera
  4. Setting an image avatar via media library
  5. Tested avatar update flow after being logged in to make sure I didn't regress anything

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable