[native] Introduce new RegistrationUserAvatarCameraModal screen for registration flow
ClosedPublic
Actions

Authored by ashoat on May 31 2023, 1:11 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMMa7453042ae47: [native] Introduce new RegistrationUserAvatarCameraModal screen for…

Summary

For photo avatar selection, our current pattern in the native app is to show another screen that handles this.

This diff continues that pattern, but introduces a new screen for the registration flow. Luckily we already have the scaffolding for this, as we needed separate screens for ThreadAvatarCameraModal and UserAvatarCameraModal already.

Depends on D8043

Test Plan

This was tested in combination with the rest of the stack. I tested:

ENS flow, both when user has an ENS avatar and when they don't
Setting an emoji avatar
Setting an image avatar via camera
Setting an image avatar via media library
Tested avatar update flow after being logged in to make sure I didn't regress anything

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 31 2023, 1:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 31 2023, 1:11 PM

ashoat added a child revision: D8045: [lib] Introduce new GenericUserInfoWithAvatar type.May 31 2023, 1:15 PM

ashoat added inline comments.May 31 2023, 1:28 PM

native/media/camera-modal.react.js
229–233 ↗	(On Diff #27322)	Since it's not all `AppNavigationProp` anymore, I had to replace my fancy `$ObjMapi` with this union
508 ↗	(On Diff #27322)	This is used to lock / unlock orientation. `CameraModal` normally relocks orientation as soon as the dismissal starts, but in this case we'll wait until the component unrenders to relock orientation If we want to improve this, I can try to look for a more generic ReactNav to check if the screen is active / dismissing
588 ↗	(On Diff #27322)	No need to animate `opacity` here for the registration flow, since it's being displayed in a stack instead of as an overlay / modal
860 ↗	(On Diff #27322)	`goBackOnce` is actually present in all navigators, since React Navigation includes action creators from parent navigators in child navigators The only check that's actually necessary here is the `overlayContext` one, but Flow needs the check on `goBackOnce`
native/media/registration-user-avatar-camera-modal.react.js
16 ↗	(On Diff #27322)	This screen isn't actually used until D8047. I usually try to include callsites / usages in the same diff, but in this case I think it's more readable to separate it out