Page MenuHomePhabricator

[native] Refactor the members list to support any variety of role labels
ClosedPublic

Authored by rohan on Jun 1 2023, 4:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 8:43 AM
Unknown Object (File)
Fri, Apr 5, 8:37 AM
Unknown Object (File)
Mar 12 2024, 12:33 PM
Unknown Object (File)
Mar 7 2024, 4:27 AM
Unknown Object (File)
Mar 7 2024, 3:44 AM
Unknown Object (File)
Mar 7 2024, 3:12 AM
Unknown Object (File)
Mar 7 2024, 1:59 AM
Unknown Object (File)
Mar 6 2024, 11:42 PM

Details

Summary

This is the same as D8067, except on native.

Depends on D8067

Test Plan

Please see below for what the changes look like (again, for testing I allowed 'Members' to display, but only Admin/custom roles will be shown)

Simulator Screen Shot - iPhone 14 Pro - 2023-06-01 at 18.19.13.png (2×1 px, 244 KB)

Simulator Screen Shot - iPhone 14 Pro - 2023-06-01 at 18.19.03.png (2×1 px, 243 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Jun 1 2023, 4:41 PM

Rename 'parent admin' to 'Admins'

atul added a subscriber: ted.

Code change looks fine

CC @ashoat for copy (should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)

CC @ted for design (current design doesn't looks great imo. Text seems busy + don't think it looks great left-aligned with avatar on next line. Could we consider alternative approaches? I've seen other messaging apps indicate admin vs. "member" with a crown icon for example. Maybe roles could have icons?)

This revision is now accepted and ready to land.Jun 6 2023, 8:20 AM

(should we "singularize" "Members" and "Admins" so it appears as "Member" and "Admin"?)

Thought about this a bit with @ted, but we concluded that when users are able to come up with their own titles for roles, it might be a bit weird / complicated to "singularize" the user-provided titles

CC @ted for design (current design doesn't looks great imo. Text seems busy + don't think it looks great left-aligned with avatar on next line. Could we consider alternative approaches? I've seen other messaging apps indicate admin vs. "member" with a crown icon for example. Maybe roles could have icons?)

I think for Roles, icons might be a bit tough since there isn't always going to be just admins and "members". Communities could have multiple different roles which might get messy in terms of displaying icons for the needed roles. I think displaying the role names work, just needs to be laid out a bit differently. Possibly having the Role name be horizontally aligned on the same line.

With the new roles feature, we show the roles for the members list on web now as well, so mobile should match that.

I'll work on a solution!

Preemptively remove the check for a parent admin. Tested with the changes
made in D8072