Differential D8072
[lib] Remove parent admin from members list if they are not part of the thread Authored by rohan on Jun 2 2023, 4:41 AM. Tags None Referenced Files
Subscribers
Details As mentioned in DES-44, there are two changes we want to make to 'Parent admins'. The first (handled in other diffs already), involves Depends on D8068 Confirmed that chats that don't actually involve the local parent admin (user ID 256) will no longer show them in the members list. Chats that do, however, will still show them. Chat where the parent admin is not a member of the chat  After:  Chat where the parent admin is a member of the chat  After (no changes): 
Diff Detail
Event TimelineComment Actions This diff makes sense, but from a code search it looks like it might impact ThreadSettingsLeaveThread and its use of otherUsersButNoOtherAdmins. In ThreadSettingsLeaveThread, we want to prevent somebody from leaving a chat if they are the only admin. I think it's important to consider "parent admins" there... otherwise, I think I'll be prevented from leaving any chats in eg. Comm. Not 100% sure if this is true, but can you investigate? Comment Actions It looks like baseOtherUsersButNoOtherAdmins will early check for if there is an Admin role present for the thread - if not, it returns false. So in the case of what looks to be all threads within a community, it will always be false since it seems like the Admins role is present only at the top-level community root channel, so you would be able to leave any of those. In regards to the top level community channel, it seems to function as before:
Once another member has access to the "Admins" role however, you'll be able to leave: Let me know if that answers your question! Comment Actions Okay, cool. I'm a bit worried that in the future we might introduce an "admin" role for a channel in a community, and in that scenario this code would break ThreadSettingsLeaveThread's usage of otherUsersButNoOtherAdmins. But I guess we can address that when we get there... |