Page MenuHomePhabricator
Differential D8097

[native] Display pinned messages not present in Redux
ClosedPublic
Actions

Authored by rohan on Jun 5 2023, 3:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 6:50 AM
Unknown Object (File)
Wed, Mar 19, 11:17 PM
Unknown Object (File)
Fri, Mar 14, 5:31 AM
Unknown Object (File)
Thu, Mar 13, 3:16 AM
Unknown Object (File)
Tue, Mar 4, 5:53 AM
Unknown Object (File)
Sat, Mar 1, 4:43 PM
Unknown Object (File)
Sat, Mar 1, 4:43 PM
Unknown Object (File)
Sat, Mar 1, 4:43 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ginsu
Commits
rCOMM89c8a4f1273a: [native] Display pinned messages not present in Redux
Summary

This is the same as D8096, but for native.

Depends on D8096

Test Plan

Please see the before and after videos below

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Jun 5 2023, 3:13 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 5 2023, 3:13 PM
rohan edited the test plan for this revision. (Show Details)Jun 5 2023, 3:14 PM
rohan attached a referenced file: F572683: Simulator Screen Recording - iPhone 14 Pro - 2023-06-05 at 18.09.55.mp4. (Show Details)
rohan attached a referenced file: F572680: Simulator Screen Recording - iPhone 14 Pro - 2023-06-05 at 18.11.07.mp4. (Show Details)
rohan edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B20028: Diff 27448.Jun 5 2023, 3:32 PM
rohan requested review of this revision.Jun 5 2023, 3:32 PM
rohan updated this revision to Diff 27458.Jun 6 2023, 3:18 AM

Remove comment

Harbormaster completed remote builds in B20036: Diff 27458.Jun 6 2023, 3:35 AM
inka accepted this revision.Jun 6 2023, 6:49 AM
This revision is now accepted and ready to land.Jun 6 2023, 6:49 AM
Closed by commit rCOMM89c8a4f1273a: [native] Display pinned messages not present in Redux (authored by rohan). · Explain WhyJun 6 2023, 9:27 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM89c8a4f1273a: [native] Display pinned messages not present in Redux.
inka mentioned this in D8982: [keyserver/lib/web/native] Modify fetchRelatedMessages to fetch toggle_pin messages.Aug 29 2023, 4:07 AM

Revision Contents
Changeset List

PathSize
native/
chat/
9 lines

Diff 27481

View Options

native/chat/message-results-screen.react.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines