Paths

Table of Contentst

comm-dev.sh - remove unnecessary 'exit 1's
ClosedPublic
Actions

Authored by bartek on Jun 12 2023, 7:28 AM.

Tags

None

Referenced Files

	F3244806: D8184.diff
	Thu, Nov 14, 2:54 PM

	Unknown Object (File)
	Tue, Nov 5, 12:51 PM

	Unknown Object (File)
	Tue, Nov 5, 9:16 AM

	Unknown Object (File)
	Mon, Nov 4, 8:23 AM

	Unknown Object (File)
	Mon, Nov 4, 8:23 AM

	Unknown Object (File)
	Mon, Nov 4, 8:23 AM

	Unknown Object (File)
	Fri, Nov 1, 9:30 AM

	Unknown Object (File)
	Fri, Nov 1, 9:30 AM

Subscribers

Details

Reviewers

• jon

Commits

rCOMMd978cf9b6c46: comm-dev.sh - remove unnecessary 'exit 1's

Summary

I landed D8181 while @jon was requesting changes so applying the suggestion in this diff. These exit 1 were indeed rendundant.

Test Plan

Shellcheck passes

Diff Detail

Repository

rCOMM Comm

Branch

barthap/shellchech2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 12 2023, 7:28 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 12 2023, 7:28 AM

bartek published this revision for review.Jun 12 2023, 7:33 AM

bartek mentioned this in D8181: [shellcheck] Disable SC2317 in comm-dev.sh.Jun 12 2023, 7:38 AM

Harbormaster completed remote builds in B20184: Diff 27650.Jun 12 2023, 7:46 AM

• jon accepted this revision.Jun 12 2023, 9:50 AM

This revision is now accepted and ready to land.Jun 12 2023, 9:50 AM

Closed by commit rCOMMd978cf9b6c46: comm-dev.sh - remove unnecessary 'exit 1's (authored by bartek). · Explain WhyJun 12 2023, 11:18 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd978cf9b6c46: comm-dev.sh - remove unnecessary 'exit 1's.

Revision Contents
Changeset List

Path

Size

scripts/

comm-dev.sh

4 lines

Diff 27650

View Options

comm-dev.sh - remove unnecessary 'exit 1'sClosedPublicActions