[native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 14 2023, 11:31 AM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMMa5767512279d: [native] Pull `displayFailureAlert` out of `EditUserAvatarProvider`

Summary

As part of making EditUserAvatarProvider "platform-agnostic" so it can be used across web and native, we're pulling displayFailureAlert (which uses react-native:Alert.alert(...)) out of EditUserAvatarProvider.

We will similarly need to pass selectFromGallery(...) and useUploadSelectedMedia as props to make EditUserAvatarProvider "fully" platform-agnostic.

Test Plan

Killed keyserver to ensure update avatar request would fail
Ensured that Alert was displayed on native as expected:

Simulator Screenshot - iPhone 14 Pro - 2023-06-14 at 14.16.51.png (2×1 px, 597 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 14 2023, 11:31 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 14 2023, 11:31 AM

atul edited the test plan for this revision. (Show Details)Jun 14 2023, 11:31 AM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B20266: Diff 27778.Jun 14 2023, 11:53 AM

atul requested review of this revision.Jun 14 2023, 11:53 AM

atul added a child revision: D8215: [native] Pull `selectFromGallery`/`useUploadSelectedMedia` out from `EditUserAvatarProvider`.Jun 14 2023, 11:53 AM

atul mentioned this in D8216: [lib] Move newly platform-agnostic `EditUserAvatarProvider` to `lib`.Jun 14 2023, 12:08 PM

Code looks good, but pls see comment inline

native/root.react.js
74–80 ↗	(On Diff #27778)	Personally not a fan of putting this logic in the `root.react.js` file, is there a utils file we could stick this in?

This revision is now accepted and ready to land.Jun 14 2023, 12:14 PM

atul added inline comments.Jun 14 2023, 12:16 PM

native/root.react.js
74–80 ↗	(On Diff #27778)	Ah yeah left a note in subsequent diff, but later in the stack once we move `EditUserAvatarProvider` to `lib` (as `BaseEditUserAvatarProvider`), we introduce a new `NativeEditUserAvatarProvider` component that handles passing platform-specific props to `BaseEditUserAvatarProvider`.
74–80 ↗	(On Diff #27778)	https://phab.comm.dev/D8215#242718